From 34e86b2697e33ea85f8aef830f30ed3acb816a81 Mon Sep 17 00:00:00 2001
From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 22 Oct 2024 11:53:25 +0200
Subject: [PATCH] dnsdist: Fix Coverity warning 445614: " Argument cannot be
 negative"

---
 pdns/dnsdistdist/dnsdist-cache.cc | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/pdns/dnsdistdist/dnsdist-cache.cc b/pdns/dnsdistdist/dnsdist-cache.cc
index 841e37a442..e3522a38e8 100644
--- a/pdns/dnsdistdist/dnsdist-cache.cc
+++ b/pdns/dnsdistdist/dnsdist-cache.cc
@@ -484,7 +484,11 @@ uint64_t DNSDistPacketCache::getEntriesCount()
 
 uint64_t DNSDistPacketCache::dump(int fileDesc, bool rawResponse)
 {
-  auto filePtr = pdns::UniqueFilePtr(fdopen(dup(fileDesc), "w"));
+  auto fileDescDuplicated = dup(fileDesc);
+  if (fileDescDuplicated < 0) {
+    return 0;
+  }
+  auto filePtr = pdns::UniqueFilePtr(fdopen(fileDescDuplicated, "w"));
   if (filePtr == nullptr) {
     return 0;
   }
-- 
2.47.2