From c184177a27526fecada91f315e9fab73c54a3e9d Mon Sep 17 00:00:00 2001
From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Mon, 10 Mar 2025 14:14:52 +0100
Subject: [PATCH] rec: fix libsnmp define and make dnsdist's meson.build the
 only one

---
 meson/libsnmp/meson.build                  | 35 ++++++++++++----------
 pdns/dnsdistdist/meson/libsnmp             |  1 +
 pdns/dnsdistdist/meson/libsnmp/meson.build | 33 --------------------
 3 files changed, 20 insertions(+), 49 deletions(-)
 create mode 120000 pdns/dnsdistdist/meson/libsnmp
 delete mode 100644 pdns/dnsdistdist/meson/libsnmp/meson.build

diff --git a/meson/libsnmp/meson.build b/meson/libsnmp/meson.build
index a39100ab58..cdf26a9e5b 100644
--- a/meson/libsnmp/meson.build
+++ b/meson/libsnmp/meson.build
@@ -1,30 +1,33 @@
 opt_libsnmp = get_option('snmp')
 
-dep_libsnmp = declare_dependency()
+dep_libsnmp = dependency('', required: false)
 
-if get_option('snmp')
+if opt_libsnmp
     snmp_config = find_program('net-snmp-config', required: true)
-    snmp_ldflags_res = run_command(snmp_config, '--libs', check: true)
+    snmp_ldflags_res = run_command(snmp_config, '--netsnmp-agent-libs', check: true)
     snmp_ldflags = snmp_ldflags_res.stdout().strip().split()
-    snmp_ldflags_res = run_command(snmp_config, '--agent-libs', check: true)
-    snmp_ldflags += snmp_ldflags_res.stdout().strip().split()
 
     dep_libsnmp = declare_dependency(
       link_args: snmp_ldflags,
     )
-endif
 
-if dep_libsnmp.found()
-  funcs = [
-    'snmp_select_info2',
-  ]
+    if dep_libsnmp.found()
+        funcs = [
+            'snmp_select_info2',
+        ]
 
-  foreach func: funcs
-    define = 'HAVE_' + func.to_upper()
-    have_func = cxx.has_function(func, dependencies: dep_libsnmp)
-    conf.set(define, have_func, description: 'Have libsnmp ' + func)
-  endforeach
+        foreach func: funcs
+            define = 'HAVE_' + func.to_upper()
+            have_func = cxx.has_function(func, dependencies: dep_libsnmp, prefix: '''#include <net-snmp/net-snmp-config.h>
+                #include <net-snmp/definitions.h>
+                #include <net-snmp/types.h>
+                #include <net-snmp/utilities.h>
+                #include <net-snmp/config_api.h>
+                #include <net-snmp/session_api.h>''')
+            conf.set(define, have_func, description: 'Have libsnmp ' + func)
+        endforeach
+   endif
 endif
 
-conf.set('HAVE_LIBSSNMP', dep_libsnmp.found(), description: 'libsnmp')
+conf.set('HAVE_NET_SNMP', dep_libsnmp.found(), description: 'libsnmp')
 summary('SNMP', dep_libsnmp.found(), bool_yn: true, section: 'Configuration')
diff --git a/pdns/dnsdistdist/meson/libsnmp b/pdns/dnsdistdist/meson/libsnmp
new file mode 120000
index 0000000000..d2e7260431
--- /dev/null
+++ b/pdns/dnsdistdist/meson/libsnmp
@@ -0,0 +1 @@
+../../../meson/libsnmp
\ No newline at end of file
diff --git a/pdns/dnsdistdist/meson/libsnmp/meson.build b/pdns/dnsdistdist/meson/libsnmp/meson.build
deleted file mode 100644
index cdf26a9e5b..0000000000
--- a/pdns/dnsdistdist/meson/libsnmp/meson.build
+++ /dev/null
@@ -1,33 +0,0 @@
-opt_libsnmp = get_option('snmp')
-
-dep_libsnmp = dependency('', required: false)
-
-if opt_libsnmp
-    snmp_config = find_program('net-snmp-config', required: true)
-    snmp_ldflags_res = run_command(snmp_config, '--netsnmp-agent-libs', check: true)
-    snmp_ldflags = snmp_ldflags_res.stdout().strip().split()
-
-    dep_libsnmp = declare_dependency(
-      link_args: snmp_ldflags,
-    )
-
-    if dep_libsnmp.found()
-        funcs = [
-            'snmp_select_info2',
-        ]
-
-        foreach func: funcs
-            define = 'HAVE_' + func.to_upper()
-            have_func = cxx.has_function(func, dependencies: dep_libsnmp, prefix: '''#include <net-snmp/net-snmp-config.h>
-                #include <net-snmp/definitions.h>
-                #include <net-snmp/types.h>
-                #include <net-snmp/utilities.h>
-                #include <net-snmp/config_api.h>
-                #include <net-snmp/session_api.h>''')
-            conf.set(define, have_func, description: 'Have libsnmp ' + func)
-        endforeach
-   endif
-endif
-
-conf.set('HAVE_NET_SNMP', dep_libsnmp.found(), description: 'libsnmp')
-summary('SNMP', dep_libsnmp.found(), bool_yn: true, section: 'Configuration')
-- 
2.47.2