From 43bfd8e96f7ce8a95abdc65ab0d6fb1123e3d7d4 Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Tue, 11 Mar 2025 10:59:32 +0100 Subject: [PATCH] Tidy annotations --- pdns/recursordist/syncres.cc | 1 + pdns/recursordist/test-syncres_cc1.cc | 2 ++ 2 files changed, 3 insertions(+) diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc index a384f5966f..140ef7a45a 100644 --- a/pdns/recursordist/syncres.cc +++ b/pdns/recursordist/syncres.cc @@ -4183,6 +4183,7 @@ static void allowAdditionalEntry(std::unordered_set& allowedAdditionals } } +// NOLINTNEXTLINE(readability-function-cognitive-complexity) void SyncRes::sanitizeRecords(const std::string& prefix, LWResult& lwr, const DNSName& qname, const QType qtype, const DNSName& auth, bool wasForwarded, bool rdQuery) { const bool wasForwardRecurse = wasForwarded && rdQuery; diff --git a/pdns/recursordist/test-syncres_cc1.cc b/pdns/recursordist/test-syncres_cc1.cc index d9415479d2..713405e8de 100644 --- a/pdns/recursordist/test-syncres_cc1.cc +++ b/pdns/recursordist/test-syncres_cc1.cc @@ -1483,6 +1483,7 @@ BOOST_AUTO_TEST_CASE(test_following_cname_with_a) const DNSName target("cname.powerdns.com."); const DNSName cnameTarget("cname-target.powerdns.com"); + // NOLINTNEXTLINE(performance-unnecessary-value-param) resolver->setAsyncCallback([&](const ComboAddress& address, const DNSName& domain, int /* type */, bool /* doTCP */, bool /* sendRDQuery */, int /* EDNS0Level */, struct timeval* /* now */, boost::optional& /* srcmask */, boost::optional /* context */, LWResult* res, bool* /* chained */) { if (isRootServer(address)) { setLWResult(res, 0, false, false, true); @@ -1531,6 +1532,7 @@ BOOST_AUTO_TEST_CASE(test_following_cname_chain_with_a) const DNSName cnameTarget1("cname-target1.powerdns.com"); const DNSName cnameTarget("cname-target.powerdns.com"); + // NOLINTNEXTLINE(performance-unnecessary-value-param) resolver->setAsyncCallback([&](const ComboAddress& address, const DNSName& domain, int /* type */, bool /* doTCP */, bool /* sendRDQuery */, int /* EDNS0Level */, struct timeval* /* now */, boost::optional& /* srcmask */, boost::optional /* context */, LWResult* res, bool* /* chained */) { if (isRootServer(address)) { setLWResult(res, 0, false, false, true); -- 2.47.2