From 348ed1e6dabd8c9f13bd2ba1a8f1b064b3b5d8ab Mon Sep 17 00:00:00 2001
From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 4 Apr 2025 11:10:30 +0200
Subject: [PATCH] Replace nested if with switch.

---
 pdns/packethandler.cc | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 543c2634cd..47131e91eb 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -1591,20 +1591,22 @@ bool PacketHandler::opcodeQueryInner2(DNSPacket& pkt, queryState &state, bool re
 
   if(d_sd.qname==pkt.qdomain) {
     if(!d_dk.isPresigned(d_sd.qname)) {
-      if(pkt.qtype.getCode() == QType::DNSKEY) {
+      switch (pkt.qtype.getCode()) {
+      case QType::DNSKEY:
         if(addDNSKEY(pkt, state.r)) {
           return true;
         }
-      }
-      else if(pkt.qtype.getCode() == QType::CDNSKEY) {
+        break;
+      case QType::CDNSKEY:
         if(addCDNSKEY(pkt,state.r)) {
           return true;
         }
-      }
-      else if(pkt.qtype.getCode() == QType::CDS) {
+        break;
+      case QType::CDS:
         if(addCDS(pkt,state.r)) {
           return true;
         }
+        break;
       }
     }
     if(pkt.qtype.getCode() == QType::NSEC3PARAM) {
-- 
2.47.2