From 7bc9c61fccd5f5dd9bd148d5ab902d7544c10d71 Mon Sep 17 00:00:00 2001 From: Oliver Chen Date: Wed, 16 Apr 2025 06:17:26 +0000 Subject: [PATCH] Fix CodeQL: move code up to avoid usage after std::move --- pdns/dnsdistdist/dnsdist-configuration-yaml.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pdns/dnsdistdist/dnsdist-configuration-yaml.cc b/pdns/dnsdistdist/dnsdist-configuration-yaml.cc index 475a75660c..be82deb681 100644 --- a/pdns/dnsdistdist/dnsdist-configuration-yaml.cc +++ b/pdns/dnsdistdist/dnsdist-configuration-yaml.cc @@ -487,6 +487,8 @@ static std::shared_ptr createBackendFromConfiguration(const dns tlsCtx = getTLSContext(backendConfig.d_tlsParams); } + backendConfig.dscp = config.dscp; + auto downstream = std::make_shared(std::move(backendConfig), std::move(tlsCtx), !configCheck); #if defined(HAVE_XSK) @@ -507,8 +509,6 @@ static std::shared_ptr createBackendFromConfiguration(const dns dnsdist::ServiceDiscovery::addUpgradeableServer(downstream, autoUpgradeConf.interval, std::string(autoUpgradeConf.pool), autoUpgradeConf.doh_key, autoUpgradeConf.keep); } - backendConfig.dscp = config.dscp; - return downstream; } -- 2.47.2