From 26ca8c3e0b7f8859053f39d8ffcad7502b029a62 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Tue, 7 Oct 2025 13:40:14 +0200 Subject: [PATCH] dnsdist: Yet another clang-tidy fix Signed-off-by: Remi Gacogne --- pdns/dnsdistdist/dnsdist-backend.cc | 6 +++--- pdns/dnsdistdist/dnsdist-lbpolicies.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pdns/dnsdistdist/dnsdist-backend.cc b/pdns/dnsdistdist/dnsdist-backend.cc index 701564e96f..b55d2441a8 100644 --- a/pdns/dnsdistdist/dnsdist-backend.cc +++ b/pdns/dnsdistdist/dnsdist-backend.cc @@ -460,8 +460,8 @@ void DownstreamState::handleUDPTimeout(IDState& ids) } if (g_rings.shouldRecordResponses()) { - timespec ts{}; - gettime(&ts); + timespec now{}; + gettime(&now); dnsheader fake{}; memset(&fake, 0, sizeof(fake)); @@ -469,7 +469,7 @@ void DownstreamState::handleUDPTimeout(IDState& ids) uint16_t* flags = getFlagsFromDNSHeader(&fake); *flags = ids.internal.origFlags; - g_rings.insertResponse(ts, ids.internal.origRemote, ids.internal.qname, ids.internal.qtype, std::numeric_limits::max(), 0, fake, d_config.remote, getProtocol()); + g_rings.insertResponse(now, ids.internal.origRemote, ids.internal.qname, ids.internal.qtype, std::numeric_limits::max(), 0, fake, d_config.remote, getProtocol()); } reportTimeoutOrError(); diff --git a/pdns/dnsdistdist/dnsdist-lbpolicies.cc b/pdns/dnsdistdist/dnsdist-lbpolicies.cc index fc23139186..5bb8648c33 100644 --- a/pdns/dnsdistdist/dnsdist-lbpolicies.cc +++ b/pdns/dnsdistdist/dnsdist-lbpolicies.cc @@ -116,7 +116,7 @@ template static std::optional ge return std::nullopt; } - int randomVal = val % sum; + int randomVal = static_cast(val % sum); auto selected = std::upper_bound(poss.begin(), poss.begin() + usableServers, randomVal, [](int randomVal_, const typename T::value_type& serverPair) { return randomVal_ < serverPair.first;}); if (selected == poss.begin() + usableServers) { return std::nullopt; -- 2.47.3