From 7a1f2b844b54711f08f8b60b294858d2eef272b5 Mon Sep 17 00:00:00 2001
From: Miod Vallat <miod.vallat@powerdns.com>
Date: Wed, 30 Jul 2025 10:13:27 +0200
Subject: [PATCH] Appease clang-tidy

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---
 modules/lmdbbackend/lmdbbackend.cc | 8 ++++----
 modules/lmdbbackend/lmdbbackend.hh | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index dc0af2818..7da2de0b0 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1687,8 +1687,8 @@ bool LMDBBackend::deleteDomain(const ZoneName& domain)
     auto txn = d_tdomains->getROTransaction();
 
     DomainInfo di;
-    if (auto id = txn.get<0>(domain, di); id != 0) {
-      idvec.push_back(id);
+    if (auto domain_id = txn.get<0>(domain, di); domain_id != 0) {
+      idvec.push_back(domain_id);
     }
   }
   else {
@@ -2031,7 +2031,7 @@ bool LMDBBackend::getDomainInfo(const ZoneName& domain, DomainInfo& info, bool g
   return true;
 }
 
-int LMDBBackend::genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func)
+bool LMDBBackend::genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func)
 {
   auto txn = d_tdomains->getRWTransaction();
 
@@ -2049,7 +2049,7 @@ int LMDBBackend::genChangeDomain(const ZoneName& domain, const std::function<voi
 }
 
 // NOLINTNEXTLINE(readability-identifier-length)
-int LMDBBackend::genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func)
+bool LMDBBackend::genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func)
 {
   DomainInfo di;
 
diff --git a/modules/lmdbbackend/lmdbbackend.hh b/modules/lmdbbackend/lmdbbackend.hh
index e7db2b43d..3665533a0 100644
--- a/modules/lmdbbackend/lmdbbackend.hh
+++ b/modules/lmdbbackend/lmdbbackend.hh
@@ -333,8 +333,8 @@ private:
   void openAllTheDatabases();
   std::shared_ptr<RecordsRWTransaction> getRecordsRWTransaction(domainid_t id);
   std::shared_ptr<RecordsROTransaction> getRecordsROTransaction(domainid_t id, const std::shared_ptr<LMDBBackend::RecordsRWTransaction>& rwtxn = nullptr);
-  int genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func);
-  int genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func);
+  bool genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func);
+  bool genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func);
   static void deleteDomainRecords(RecordsRWTransaction& txn, const std::string& match);
 
   void getAllDomainsFiltered(vector<DomainInfo>* domains, const std::function<bool(DomainInfo&)>& allow);
-- 
2.47.2