From 3fa4225a6bc0966eb5fe3cc0eca290880d966d77 Mon Sep 17 00:00:00 2001 From: Miod Vallat Date: Fri, 10 Oct 2025 11:22:04 +0200 Subject: [PATCH] Remove leftover DNSBackend::maker() routines. Signed-off-by: Miod Vallat --- modules/bindbackend/bindbackend2.hh | 1 - modules/pipebackend/pipebackend.cc | 12 ------------ modules/pipebackend/pipebackend.hh | 1 - modules/remotebackend/remotebackend.cc | 11 ----------- modules/remotebackend/remotebackend.hh | 2 -- 5 files changed, 27 deletions(-) diff --git a/modules/bindbackend/bindbackend2.hh b/modules/bindbackend/bindbackend2.hh index df55e801f7..166327bcd0 100644 --- a/modules/bindbackend/bindbackend2.hh +++ b/modules/bindbackend/bindbackend2.hh @@ -194,7 +194,6 @@ public: void lookupEnd() override; void getAllDomains(vector* domains, bool getSerial, bool include_disabled = false) override; - static DNSBackend* maker(); static std::mutex s_startup_lock; void setStale(domainid_t domain_id) override; diff --git a/modules/pipebackend/pipebackend.cc b/modules/pipebackend/pipebackend.cc index da430d24a6..25c5c5ba41 100644 --- a/modules/pipebackend/pipebackend.cc +++ b/modules/pipebackend/pipebackend.cc @@ -249,18 +249,6 @@ string PipeBackend::directBackendCmd(const string& query) return oss.str(); } -//! For the dynamic loader -DNSBackend* PipeBackend::maker() -{ - try { - return new PipeBackend(); - } - catch (...) { - g_log << Logger::Error << kBackendId << " Unable to instantiate a pipebackend!" << endl; - return nullptr; - } -} - PipeBackend::~PipeBackend() { cleanup(); diff --git a/modules/pipebackend/pipebackend.hh b/modules/pipebackend/pipebackend.hh index 15535f4953..3a296d82f8 100644 --- a/modules/pipebackend/pipebackend.hh +++ b/modules/pipebackend/pipebackend.hh @@ -56,7 +56,6 @@ public: bool list(const ZoneName& target, domainid_t domain_id, bool include_disabled = false) override; bool get(DNSResourceRecord& r) override; string directBackendCmd(const string& query) override; - static DNSBackend* maker(); private: void launch(); diff --git a/modules/remotebackend/remotebackend.cc b/modules/remotebackend/remotebackend.cc index 6e11267a48..2234db2c1f 100644 --- a/modules/remotebackend/remotebackend.cc +++ b/modules/remotebackend/remotebackend.cc @@ -1011,17 +1011,6 @@ void RemoteBackend::setFresh(domainid_t domain_id) } } -DNSBackend* RemoteBackend::maker() -{ - try { - return new RemoteBackend(); - } - catch (...) { - g_log << Logger::Error << kBackendId << " Unable to instantiate a remotebackend!" << endl; - return nullptr; - }; -} - class RemoteBackendFactory : public BackendFactory { public: diff --git a/modules/remotebackend/remotebackend.hh b/modules/remotebackend/remotebackend.hh index 94bb292b42..77671e9b1a 100644 --- a/modules/remotebackend/remotebackend.hh +++ b/modules/remotebackend/remotebackend.hh @@ -208,8 +208,6 @@ public: void setStale(domainid_t domain_id) override; void setFresh(domainid_t domain_id) override; - static DNSBackend* maker(); - private: int build(); std::unique_ptr connector; -- 2.47.3