From db4d617c1cfbe74e010183a3595642434f55ea00 Mon Sep 17 00:00:00 2001 From: Marcel Raad Date: Sat, 8 Feb 2025 00:03:47 +0100 Subject: [PATCH] build: enable -Wjump-misses-init for GCC 4.5+ This should have caught https://github.com/curl/curl/issues/16246. Closes https://github.com/curl/curl/pull/16252 --- CMake/PickyWarnings.cmake | 10 ++++++++-- m4/curl-compilers.m4 | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CMake/PickyWarnings.cmake b/CMake/PickyWarnings.cmake index 2f1ddec678..b7bb20efe2 100644 --- a/CMake/PickyWarnings.cmake +++ b/CMake/PickyWarnings.cmake @@ -184,10 +184,16 @@ if(PICKY_COMPILER) -Wstrict-aliasing=3 # gcc 4.0 ) endif() - if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 4.5 AND MINGW) + if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 4.5) list(APPEND _picky_enable - -Wno-pedantic-ms-format # gcc 4.5 (MinGW-only) + -Wjump-misses-init # gcc 4.5 ) + + if(MINGW) + list(APPEND _picky_enable + -Wno-pedantic-ms-format # gcc 4.5 (MinGW-only) + ) + endif() endif() if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 4.8) list(APPEND _picky_enable diff --git a/m4/curl-compilers.m4 b/m4/curl-compilers.m4 index 49bcda0e88..cbf7dc8a3b 100644 --- a/m4/curl-compilers.m4 +++ b/m4/curl-compilers.m4 @@ -1040,6 +1040,7 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ # dnl Only gcc 4.5 or later if test "$compiler_num" -ge "405"; then + CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [jump-misses-init]) dnl Only Windows targets if test "$curl_cv_native_windows" = "yes"; then tmp_CFLAGS="$tmp_CFLAGS -Wno-pedantic-ms-format" -- 2.47.2