From b082f9f60e0009f44a43b0b046a0c8952f0c7761 Mon Sep 17 00:00:00 2001 From: Jonas Jelonek Date: Tue, 2 Sep 2025 09:38:51 +0200 Subject: [PATCH] realtek: fix model for TP-Link TL-ST1008F v2.0 Fix the model name in DTS compatible, Makefiles and board scripts by using dash instead of comma or underscore. This aligns it with other examples in OpenWrt and makes in consistent in all places where the board model is used. 'tplink,tl-st1008f,v2' --> 'tplink,tl-st1008f-v2' 'tplink,tl-st1008f_v2' --> 'tplink,tl-st1008f-v2' Fixes: 39b9b491bb ("realtek: add support for TP-Link TL-ST1008F v2.0") Fixes: #19930 Signed-off-by: Jonas Jelonek Link: https://github.com/openwrt/openwrt/pull/19934 Signed-off-by: Hauke Mehrtens --- target/linux/realtek/base-files/etc/board.d/02_network | 2 +- .../base-files/etc/uci-defaults/99_fwenv-store-ethaddr | 2 +- ...nk_tl-st1008f_v2.dts => rtl9303_tplink_tl-st1008f-v2.dts} | 2 +- target/linux/realtek/image/rtl930x.mk | 5 +++-- 4 files changed, 6 insertions(+), 5 deletions(-) rename target/linux/realtek/dts/{rtl9303_tplink_tl-st1008f_v2.dts => rtl9303_tplink_tl-st1008f-v2.dts} (99%) diff --git a/target/linux/realtek/base-files/etc/board.d/02_network b/target/linux/realtek/base-files/etc/board.d/02_network index dd2456d9dc1..0586e9e3960 100644 --- a/target/linux/realtek/base-files/etc/board.d/02_network +++ b/target/linux/realtek/base-files/etc/board.d/02_network @@ -56,7 +56,7 @@ tplink,t1600g-28ts-v3) label_mac=$(get_mac_label) lan_mac="$label_mac" ;; -tplink,tl-st1008f,v2) +tplink,tl-st1008f-v2) lan_mac=$(mtd_get_mac_ascii u-boot-env ethaddr) [ -z "$lan_mac" ] || [ "$lan_mac" = "00:e0:4c:00:00:00" ] && lan_mac=$(macaddr_random) ;; diff --git a/target/linux/realtek/base-files/etc/uci-defaults/99_fwenv-store-ethaddr b/target/linux/realtek/base-files/etc/uci-defaults/99_fwenv-store-ethaddr index adb54da9566..c2684223895 100644 --- a/target/linux/realtek/base-files/etc/uci-defaults/99_fwenv-store-ethaddr +++ b/target/linux/realtek/base-files/etc/uci-defaults/99_fwenv-store-ethaddr @@ -10,7 +10,7 @@ BOARD_CFG=/etc/board.json [ "$(rootfs_type)" = "tmpfs" ] && exit 0 case "$(board_name)" in -tplink,tl-st1008f,v2) +tplink,tl-st1008f-v2) env_ethaddr=$(macaddr_canonicalize "$(fw_printenv -n ethaddr 2>/dev/null)") # This device ships with a dummy ethaddr because it's an unmanaged switch. diff --git a/target/linux/realtek/dts/rtl9303_tplink_tl-st1008f_v2.dts b/target/linux/realtek/dts/rtl9303_tplink_tl-st1008f-v2.dts similarity index 99% rename from target/linux/realtek/dts/rtl9303_tplink_tl-st1008f_v2.dts rename to target/linux/realtek/dts/rtl9303_tplink_tl-st1008f-v2.dts index 49d7b348d55..83f99987950 100644 --- a/target/linux/realtek/dts/rtl9303_tplink_tl-st1008f_v2.dts +++ b/target/linux/realtek/dts/rtl9303_tplink_tl-st1008f-v2.dts @@ -7,7 +7,7 @@ #include / { - compatible = "tplink,tl-st1008f,v2", "realtek,rtl930x-soc"; + compatible = "tplink,tl-st1008f-v2", "realtek,rtl930x-soc"; model = "TP-Link TL-ST1008F v2.0"; memory@0 { diff --git a/target/linux/realtek/image/rtl930x.mk b/target/linux/realtek/image/rtl930x.mk index 8f53855b5bc..cf7333e3d4c 100644 --- a/target/linux/realtek/image/rtl930x.mk +++ b/target/linux/realtek/image/rtl930x.mk @@ -40,17 +40,18 @@ define Device/plasmacloud_psx10 endef TARGET_DEVICES += plasmacloud_psx10 -define Device/tplink_tl-st1008f_v2 +define Device/tplink_tl-st1008f-v2 SOC := rtl9303 UIMAGE_MAGIC := 0x93030000 DEVICE_VENDOR := TP-Link DEVICE_MODEL := TL-ST1008F DEVICE_VARIANT := v2.0 DEVICE_PACKAGES := kmod-gpio-pca953x + SUPPORTED_DEVICES += tplink,tl-st1008f,v2 IMAGE_SIZE := 31808k $(Device/kernel-lzma) endef -TARGET_DEVICES += tplink_tl-st1008f_v2 +TARGET_DEVICES += tplink_tl-st1008f-v2 define Device/vimin_vm-s100-0800ms SOC := rtl9303 -- 2.47.2