From 4ed96e54cd811c50ce1f5ef7d074fccc9d6a54a5 Mon Sep 17 00:00:00 2001 From: Sven Eckelmann Date: Tue, 4 Nov 2025 12:14:58 +0100 Subject: [PATCH] realtek: dsa: Simplify rtl83xx_setup_qos MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit It is not necessary to have two different family_id checks directly after another. It is simpler to just combine both into one. Suggested-by: Álvaro Fernández Rojas Signed-off-by: Sven Eckelmann Link: https://github.com/openwrt/openwrt/pull/20637 Signed-off-by: Álvaro Fernández Rojas --- .../files-6.12/drivers/net/dsa/rtl83xx/qos.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c b/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c index 55145b5fcfd..4794ea95768 100644 --- a/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c +++ b/target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/qos.c @@ -553,13 +553,14 @@ void __init rtl83xx_setup_qos(struct rtl838x_switch_priv *priv) pr_info("In %s\n", __func__); - if (priv->family_id == RTL8380_FAMILY_ID) + switch (priv->family_id) { + case RTL8380_FAMILY_ID: rtl838x_config_qos(); - else if (priv->family_id == RTL8390_FAMILY_ID) - rtl839x_config_qos(); - - if (priv->family_id == RTL8380_FAMILY_ID) rtl838x_rate_control_init(priv); - else if (priv->family_id == RTL8390_FAMILY_ID) + break; + case RTL8390_FAMILY_ID: + rtl839x_config_qos(); rtl839x_rate_control_init(priv); + break; + } } -- 2.47.3