From de6956262362a15244b4fe716ae74b1a00bb8a1e Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Sat, 19 Jul 2025 09:47:33 +0900 Subject: [PATCH] tree-wide: add missing '=' in short comments for function argument --- src/analyze/analyze-unit-shell.c | 2 +- src/boot/pe.c | 8 ++++---- src/boot/secure-boot.c | 2 +- src/core/main.c | 2 +- src/cryptenroll/cryptenroll-password.c | 2 +- src/firstboot/firstboot.c | 2 +- src/home/user-record-password-quality.c | 2 +- src/journal-remote/journal-upload.c | 2 +- src/journal/journald-config.c | 2 +- src/journal/journald-manager.c | 4 ++-- src/libsystemd/sd-event/sd-event.c | 6 +++--- src/login/logind-session.c | 2 +- src/login/pam_systemd.c | 2 +- src/shared/password-quality-util-passwdqc.c | 2 +- src/sysext/sysext.c | 2 +- src/udev/udev-rules.c | 2 +- 16 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/analyze/analyze-unit-shell.c b/src/analyze/analyze-unit-shell.c index 43eb65932ee..607c6af6763 100644 --- a/src/analyze/analyze-unit-shell.c +++ b/src/analyze/analyze-unit-shell.c @@ -82,7 +82,7 @@ int verb_unit_shell(int argc, char *argv[], void *userdata) { "(unit-shell-ns)", "(unit-shell)", /* except_fds= */ NULL, - /* n_except_fds */ 0, + /* n_except_fds= */ 0, FORK_RESET_SIGNALS|FORK_DEATHSIG_SIGKILL, pidns_fd, mntns_fd, diff --git a/src/boot/pe.c b/src/boot/pe.c index beab0eb670a..8f384630417 100644 --- a/src/boot/pe.c +++ b/src/boot/pe.c @@ -366,8 +366,8 @@ static void pe_locate_sections( n_section_table, section_names, validate_base, - /* device_base */ NULL, - /* device */ NULL, + /* device_table = */ NULL, + /* device = */ NULL, sections); /* It doesn't make sense not to provide validate_base here */ @@ -386,8 +386,8 @@ static void pe_locate_sections( n_section_table, hwid_section_names, validate_base, - /* device_table */ NULL, - /* device */ NULL, + /* device_table = */ NULL, + /* device = */ NULL, hwids_section); if (PE_SECTION_VECTOR_IS_SET(hwids_section)) { diff --git a/src/boot/secure-boot.c b/src/boot/secure-boot.c index 3a3a7540091..883e8487e47 100644 --- a/src/boot/secure-boot.c +++ b/src/boot/secure-boot.c @@ -161,7 +161,7 @@ EFI_STATUS secure_boot_enroll_at(EFI_FILE *root_dir, const char16_t *path, bool } if (need_custom_mode && !custom_mode_enabled()) { - err = set_custom_mode(/* enable */ true); + err = set_custom_mode(/* enable = */ true); if (err != EFI_SUCCESS) { log_error_status(err, "Failed to enable custom mode: %m"); goto out_deallocate; diff --git a/src/core/main.c b/src/core/main.c index 6c44b4e00fd..4fc870d6c0e 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -1421,7 +1421,7 @@ static int os_release_status(void) { } } - if (support_end && os_release_support_ended(support_end, /* quiet */ false, NULL) > 0) + if (support_end && os_release_support_ended(support_end, /* quiet = */ false, /* ret_eol = */ NULL) > 0) /* pretty_name may include the version already, so we'll print the version only if we * have it and we're not using pretty_name. */ status_printf(ANSI_HIGHLIGHT_RED " !! " ANSI_NORMAL, 0, diff --git a/src/cryptenroll/cryptenroll-password.c b/src/cryptenroll/cryptenroll-password.c index 8c7e38b82cc..7761aba21f8 100644 --- a/src/cryptenroll/cryptenroll-password.c +++ b/src/cryptenroll/cryptenroll-password.c @@ -188,7 +188,7 @@ int enroll_password( } } - r = check_password_quality(new_password, /* old */ NULL, /* user */ NULL, &error); + r = check_password_quality(new_password, /* old = */ NULL, /* user = */ NULL, &error); if (ERRNO_IS_NEG_NOT_SUPPORTED(r)) log_warning("Password quality check is not supported, proceeding anyway."); else if (r < 0) diff --git a/src/firstboot/firstboot.c b/src/firstboot/firstboot.c index 4462086e782..5ed6d3a9d2d 100644 --- a/src/firstboot/firstboot.c +++ b/src/firstboot/firstboot.c @@ -824,7 +824,7 @@ static int prompt_root_password(int rfd) { break; } - r = check_password_quality(*a, /* old */ NULL, "root", &error); + r = check_password_quality(*a, /* old = */ NULL, "root", &error); if (ERRNO_IS_NEG_NOT_SUPPORTED(r)) log_warning("Password quality check is not supported, proceeding anyway."); else if (r < 0) diff --git a/src/home/user-record-password-quality.c b/src/home/user-record-password-quality.c index 844c42c52b2..b23f717c0e1 100644 --- a/src/home/user-record-password-quality.c +++ b/src/home/user-record-password-quality.c @@ -63,7 +63,7 @@ int user_record_check_password_quality( continue; /* If there are no old passwords, let's call check_password_quality() without any. */ - r = check_password_quality(*pp, /* old */ NULL, hr->user_name, &auxerror); + r = check_password_quality(*pp, /* old = */ NULL, hr->user_name, &auxerror); if (r <= 0) goto error; } diff --git a/src/journal-remote/journal-upload.c b/src/journal-remote/journal-upload.c index 46a58e228b4..d669d27274f 100644 --- a/src/journal-remote/journal-upload.c +++ b/src/journal-remote/journal-upload.c @@ -682,7 +682,7 @@ static int parse_config(void) { { "Upload", "TrustedCertificateFile", config_parse_path_or_ignore, 0, &arg_trust }, { "Upload", "NetworkTimeoutSec", config_parse_sec, 0, &arg_network_timeout_usec }, { "Upload", "Header", config_parse_header, 0, &arg_headers }, - { "Upload", "Compression", config_parse_compression, /* with_level */ true, &arg_compression }, + { "Upload", "Compression", config_parse_compression, /* with_level = */ true, &arg_compression }, { "Upload", "ForceCompression", config_parse_bool, 0, &arg_force_compression }, {} }; diff --git a/src/journal/journald-config.c b/src/journal/journald-config.c index 4a514cd573f..dd2e29e2962 100644 --- a/src/journal/journald-config.c +++ b/src/journal/journald-config.c @@ -377,7 +377,7 @@ int manager_dispatch_reload_signal(sd_event_source *s, const struct signalfd_sig manager_reopen_journals(m, &old); log_info("Config file reloaded."); - (void) sd_notify(/* unset_environment */ false, NOTIFY_READY_MESSAGE); + (void) sd_notify(/* unset_environment = */ false, NOTIFY_READY_MESSAGE); return 0; } diff --git a/src/journal/journald-manager.c b/src/journal/journald-manager.c index bd2a05489df..743aea3868a 100644 --- a/src/journal/journald-manager.c +++ b/src/journal/journald-manager.c @@ -1467,7 +1467,7 @@ int manager_relinquish_var(Manager *m) { log_debug("Relinquishing %s...", m->system_storage.path); - (void) manager_system_journal_open(m, /* flush_requested */ false, /* relinquish_requested=*/ true); + (void) manager_system_journal_open(m, /* flush_requested = */ false, /* relinquish_requested = */ true); m->system_journal = journal_file_offline_close(m->system_journal); ordered_hashmap_clear(m->user_journals); @@ -2290,7 +2290,7 @@ void manager_reopen_journals(Manager *m, const JournalConfig *old) { (void) manager_system_journal_open(m, /* flush_requested = */ false, /* relinquish_requested = */ false); /* To make the storage related settings applied, vacuum the storage. */ - manager_vacuum(m, /* verbose */ false); + manager_vacuum(m, /* verbose = */ false); } int manager_new(Manager **ret) { diff --git a/src/libsystemd/sd-event/sd-event.c b/src/libsystemd/sd-event/sd-event.c index 869747e929d..6cb496c5418 100644 --- a/src/libsystemd/sd-event/sd-event.c +++ b/src/libsystemd/sd-event/sd-event.c @@ -3631,7 +3631,7 @@ static int process_timer( * again. */ assert(s->ratelimited); - r = event_source_leave_ratelimit(s, /* run_callback */ true); + r = event_source_leave_ratelimit(s, /* run_callback = */ true); if (r < 0) return r; else if (r == 1) @@ -5116,7 +5116,7 @@ _public_ int sd_event_source_set_ratelimit(sd_event_source *s, uint64_t interval /* When ratelimiting is configured we'll always reset the rate limit state first and start fresh, * non-ratelimited. */ - r = event_source_leave_ratelimit(s, /* run_callback */ false); + r = event_source_leave_ratelimit(s, /* run_callback = */ false); if (r < 0) return r; @@ -5179,7 +5179,7 @@ _public_ int sd_event_source_leave_ratelimit(sd_event_source *s) { if (!s->ratelimited) return 0; - r = event_source_leave_ratelimit(s, /* run_callback */ false); + r = event_source_leave_ratelimit(s, /* run_callback = */ false); if (r < 0) return r; diff --git a/src/login/logind-session.c b/src/login/logind-session.c index db835d56d7d..071bdb54417 100644 --- a/src/login/logind-session.c +++ b/src/login/logind-session.c @@ -734,7 +734,7 @@ static int session_dispatch_stop_on_idle(sd_event_source *source, uint64_t t, vo if (idle) { log_info("Session \"%s\" of user \"%s\" is idle, stopping.", s->id, s->user->user_record->user_name); - return session_stop(s, /* force */ true); + return session_stop(s, /* force = */ true); } r = sd_event_source_set_time( diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c index a2f0a7373a8..1318211105b 100644 --- a/src/login/pam_systemd.c +++ b/src/login/pam_systemd.c @@ -1812,7 +1812,7 @@ _public_ PAM_EXTERN int pam_sm_close_session( /* desktop= */ NULL, /* area= */ NULL, &debug, - /* default_capability_bounding_set */ NULL, + /* default_capability_bounding_set= */ NULL, /* default_capability_ambient_set= */ NULL) < 0) return PAM_SESSION_ERR; diff --git a/src/shared/password-quality-util-passwdqc.c b/src/shared/password-quality-util-passwdqc.c index 004203d17e3..f4ecc6ce66d 100644 --- a/src/shared/password-quality-util-passwdqc.c +++ b/src/shared/password-quality-util-passwdqc.c @@ -127,7 +127,7 @@ int check_password_quality( check_reason = sym_passwdqc_check(¶ms->qc, password, old, &pw); } else - check_reason = sym_passwdqc_check(¶ms->qc, password, old, /* pw */ NULL); + check_reason = sym_passwdqc_check(¶ms->qc, password, old, /* pw = */ NULL); if (check_reason) { if (ret_error) { diff --git a/src/sysext/sysext.c b/src/sysext/sysext.c index 0d17459d6ff..005ea6d977d 100644 --- a/src/sysext/sysext.c +++ b/src/sysext/sysext.c @@ -254,7 +254,7 @@ static int need_reload( const char *extension_reload_manager = NULL; int b; - r = load_extension_release_pairs(arg_root, image_class, *extension, /* relax_extension_release_check */ true, &extension_release); + r = load_extension_release_pairs(arg_root, image_class, *extension, /* relax_extension_release_check = */ true, &extension_release); if (r < 0) { log_debug_errno(r, "Failed to parse extension-release metadata of %s, ignoring: %m", *extension); continue; diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c index b7fc0a675c5..1f99b54a0d7 100644 --- a/src/udev/udev-rules.c +++ b/src/udev/udev-rules.c @@ -954,7 +954,7 @@ static int parse_token( if (is_case_insensitive) return log_line_invalid_prefix(rule_line, key); - r = rule_line_add_token(rule_line, TK_M_PROGRAM, op, value, NULL, /* is_case_insensitive */ false, token_str); + r = rule_line_add_token(rule_line, TK_M_PROGRAM, op, value, NULL, /* is_case_insensitive = */ false, token_str); } else if (streq(key, "IMPORT")) { if (isempty(attr)) return log_line_invalid_attr(rule_line, key); -- 2.47.3