From fcfff55f03afcf653eaabd2b38e5a6cfc6818d3a Mon Sep 17 00:00:00 2001 From: Alexander Moisseev Date: Thu, 6 Apr 2023 17:22:52 +0300 Subject: [PATCH] [Minor] Use a scalar variable as a dir handle instead of a bareword --- utils/rspamd_stats.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/utils/rspamd_stats.pl b/utils/rspamd_stats.pl index e90524d203..9c5f2acb07 100755 --- a/utils/rspamd_stats.pl +++ b/utils/rspamd_stats.pl @@ -678,20 +678,20 @@ sub JsonObjectElt() { sub GetLogfilesList { my ($dir) = @_; - opendir( DIR, $dir ) or die $!; + opendir( my $fh, $dir ) or die $!; my $pattern = join( '|', keys %decompressor ); my $re = qr/\.[0-9]+(?:\.(?:$pattern))?/; # Add unnumbered logs first my @logs = - grep { -f "$dir/$_" && !/$re/ } readdir(DIR); + grep { -f "$dir/$_" && !/$re/ } readdir($fh); # Add numbered logs - rewinddir(DIR); - push( @logs, ( sort numeric ( grep { -f "$dir/$_" && /$re/ } readdir(DIR) ) ) ); + rewinddir($fh); + push( @logs, ( sort numeric ( grep { -f "$dir/$_" && /$re/ } readdir($fh) ) ) ); - closedir(DIR); + closedir($fh); # Select required logs and revers their order @logs = -- 2.47.3