From 29a6977b71fd2ee2f26d5731847a13e98ccb6baf Mon Sep 17 00:00:00 2001 From: Tobias Oetiker Date: Mon, 17 Nov 2014 23:48:12 +0100 Subject: [PATCH] complain about strings that are too long when restoring to rrd --- src/rrd_restore.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/rrd_restore.c b/src/rrd_restore.c index df1f0725..190bc21e 100644 --- a/src/rrd_restore.c +++ b/src/rrd_restore.c @@ -239,11 +239,15 @@ static xmlChar* get_xml_text ( static int get_xml_string( xmlTextReaderPtr reader, char *value, - int max_len) + unsigned int max_len) { xmlChar *str; str = get_xml_text(reader); if (str != NULL){ + if (strlen((char *)str) >= max_len){ + rrd_set_error("'%s' is longer than %i",str,max_len); + return -1; + } strncpy(value,(char *)str,max_len); xmlFree(str); return 0; -- 2.47.2