From 5962d573a0bd0d4c42d57d91e8721d582cf54ae2 Mon Sep 17 00:00:00 2001 From: Rose <83477269+AtariDreams@users.noreply.github.com> Date: Sun, 29 Jan 2023 12:09:19 -0500 Subject: [PATCH] Fix-up ORs Missed a few spots --- backend/ieee1284.c | 4 ++-- cups/dest-options.c | 2 +- scheduler/conf.c | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/backend/ieee1284.c b/backend/ieee1284.c index 821315ff34..5ecf8a8347 100644 --- a/backend/ieee1284.c +++ b/backend/ieee1284.c @@ -157,7 +157,7 @@ backendGetDeviceID( * bytes. The 1284 spec says the length is stored MSB first... */ - length = (int)((((unsigned)device_id[0] & 255) << 8) + ((unsigned)device_id[1] & 255)); + length = (int)((((unsigned)device_id[0] & 255) << 8) | ((unsigned)device_id[1] & 255)); /* * Check to see if the length is larger than our buffer; first @@ -166,7 +166,7 @@ backendGetDeviceID( */ if (length > device_id_size || length < 14) - length = (int)((((unsigned)device_id[1] & 255) << 8) + ((unsigned)device_id[0] & 255)); + length = (int)((((unsigned)device_id[1] & 255) << 8) | ((unsigned)device_id[0] & 255)); if (length > device_id_size) length = device_id_size; diff --git a/cups/dest-options.c b/cups/dest-options.c index a1f01d0c63..55a75b794b 100644 --- a/cups/dest-options.c +++ b/cups/dest-options.c @@ -1621,7 +1621,7 @@ cups_collection_string( const ipp_uchar_t *date = ippGetDate(member, j); /* Date value */ - year = ((unsigned)date[0] << 8) + (unsigned)date[1]; + year = (date[0] << 8) | date[1]; if (date[9] == 0 && date[10] == 0) snprintf(temp, sizeof(temp), "%04u-%02u-%02uT%02u:%02u:%02uZ", year, date[2], date[3], date[4], date[5], date[6]); diff --git a/scheduler/conf.c b/scheduler/conf.c index 412f30c658..4e990cd29c 100644 --- a/scheduler/conf.c +++ b/scheduler/conf.c @@ -1975,8 +1975,7 @@ get_addr_and_mask(const char *value, /* I - String from config file */ mask + 3) != 4) return (0); - mask[3] |= ((unsigned)mask[0] << 24) | ((unsigned)mask[1] << 16) | - ((unsigned)mask[2] << 8); + mask[3] |= (mask[0] << 24) | (mask[1] << 16) | (mask[2] << 8); mask[0] = mask[1] = mask[2] = 0; } else -- 2.47.2