From 699ba3ea1bedfba099e6fbfee24c3d27bd5dff1c Mon Sep 17 00:00:00 2001 From: Pieter Lexis Date: Thu, 22 Feb 2018 10:34:56 +0100 Subject: [PATCH] rec: Fix AXFR timeout nits (cherry picked from commit cb6218d2b539eb225c5d1ec88227fa7136dbcc94) --- pdns/rpzloader.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pdns/rpzloader.cc b/pdns/rpzloader.cc index 7bc08cf464..8d18988869 100644 --- a/pdns/rpzloader.cc +++ b/pdns/rpzloader.cc @@ -189,8 +189,8 @@ shared_ptr loadRPZFromServer(const ComboAddress& master, const Resolver::res_t nop; vector chunk; time_t last=0; - time_t axfrStart = time(0); - time_t axfrNow = time(0); + time_t axfrStart = time(nullptr); + time_t axfrNow = time(nullptr); shared_ptr sr; while(axfr.getChunk(nop, &chunk, (axfrStart + axfrTimeout - axfrNow))) { for(auto& dr : chunk) { @@ -208,7 +208,7 @@ shared_ptr loadRPZFromServer(const ComboAddress& master, const nrecords++; } axfrNow = time(nullptr); - if (axfrNow - axfrStart > axfrTimeout) { + if (axfrNow < axfrStart || axfrNow - axfrStart > axfrTimeout) { throw PDNSException("Total AXFR time exceeded!"); } if(last != time(0)) { -- 2.47.2