From 89a7e0df60c095f6bed561d8fbaf02f70985546d Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Thu, 23 Aug 2018 17:23:18 +0200 Subject: [PATCH] dnsdist: Fix a sign-comparison warning in isEDNSOptionInOpt() --- pdns/dnsdist-ecs.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pdns/dnsdist-ecs.cc b/pdns/dnsdist-ecs.cc index ff40bd8662..1d35a84288 100644 --- a/pdns/dnsdist-ecs.cc +++ b/pdns/dnsdist-ecs.cc @@ -437,7 +437,7 @@ bool isEDNSOptionInOpt(const std::string& packet, const size_t optStart, const s size_t p = optStart + 9; uint16_t rdLen = (0x100*packet.at(p) + packet.at(p+1)); p += sizeof(rdLen); - if (11 + rdLen > optLen) { + if (rdLen > (optLen - 11)) { return false; } -- 2.47.2