From ecc435306e45a8bae9515fe2c5bb33600cc5a192 Mon Sep 17 00:00:00 2001 From: Paul Barker Date: Sun, 6 Apr 2014 23:12:26 +0100 Subject: [PATCH] Use snprintf to print to zip->format_name zip->format_name is a fixed size character array so ensure that the number of characters written to the array is appropriately limited. Signed-off-by: Paul Barker --- libarchive/archive_read_support_format_zip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libarchive/archive_read_support_format_zip.c b/libarchive/archive_read_support_format_zip.c index ab3c71e2e..dbe245e15 100644 --- a/libarchive/archive_read_support_format_zip.c +++ b/libarchive/archive_read_support_format_zip.c @@ -744,7 +744,7 @@ zip_read_local_file_header(struct archive_read *a, struct archive_entry *entry, zip->end_of_entry = 1; /* Set up a more descriptive format name. */ - sprintf(zip->format_name, "ZIP %d.%d (%s)", + snprintf(zip->format_name, sizeof(zip->format_name), "ZIP %d.%d (%s)", version / 10, version % 10, compression_name(zip->entry->compression)); a->archive.archive_format_name = zip->format_name; -- 2.47.2