From fc868bbfa88692edb369e1ce88d1d0e966df64bc Mon Sep 17 00:00:00 2001 From: Sven Panne Date: Tue, 30 May 2017 09:19:04 +0200 Subject: [PATCH] Fixed declaration and export of rrd_dump_opt_r. The previous state of affairs regarding rrd_dump_opt_r was a bit inconsistent: The dynamic library didn't export it, while the static one did. So the right way to fix it will be exporting it in both variants, because removing it from the static library would require a major version change. Furthermore, rrd_dump_opt_r is mentioned in the documentation at librrd.pod, so this is another hint for the fix. In addition, a C prototype was wmissing, so GCC complained about it. --- src/librrd.sym | 1 + src/rrd.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/librrd.sym b/src/librrd.sym index c5a707d8..a3c89c7b 100644 --- a/src/librrd.sym +++ b/src/librrd.sym @@ -11,6 +11,7 @@ rrd_dontneed rrd_dump rrd_dump_r rrd_dump_cb_r +rrd_dump_opt_r rrd_fetch rrd_fetch_r rrd_fetch_cb_register diff --git a/src/rrd.h b/src/rrd.h index be153256..239e2c37 100644 --- a/src/rrd.h +++ b/src/rrd.h @@ -292,6 +292,9 @@ struct rrd_t; unsigned long *ds_cnt, char ***ds_namv, rrd_value_t **data); + int rrd_dump_opt_r(const char *filename, + char *outname, + int opt_noheader); int rrd_dump_r( const char *filename, char *outname); -- 2.47.2