From 8f3568cb0cb9494c7312e8da46e359d9bb1d1e50 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Thu, 28 Nov 2019 11:39:51 +0100 Subject: [PATCH] dnsdist: Wait longer for the TLS ticket to arrive in our tests In TLS 1.3 the server sends the TLS ticket after the handshake has been completed, but not necessarily right after that. Ideally we would like to wait for up to several seconds, but stop waiting as soon as we receive a ticket. Unfortunately we can't ask that from `openssl s_client`, and we are currently not always waiting long enough to get a ticket, leading to spurious failures. Let's try waiting a bit longer to see if that helps. --- regression-tests.dnsdist/test_TLSSessionResumption.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/regression-tests.dnsdist/test_TLSSessionResumption.py b/regression-tests.dnsdist/test_TLSSessionResumption.py index 190a32af6d..4f9dfd6194 100644 --- a/regression-tests.dnsdist/test_TLSSessionResumption.py +++ b/regression-tests.dnsdist/test_TLSSessionResumption.py @@ -32,7 +32,7 @@ class DNSDistTLSSessionResumptionTest(DNSDistTest): try: process = subprocess.Popen(testcmd, stdout=subprocess.PIPE, stdin=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=True) # we need to wait just a bit so that the Post-Handshake New Session Ticket has the time to arrive.. - time.sleep(0.1) + time.sleep(0.5) output = process.communicate(input=b'') except subprocess.CalledProcessError as exc: raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output)) -- 2.47.2