From f20fd74abd5234a9a228a3057c112b0bfb91027a Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Wed, 29 Jan 2020 15:41:45 +0100 Subject: [PATCH] Remove the empty user-defined destructor of DNSResourceRecord Having a user-defined destructor prevents the compiler from generating implicit definition of the move constructor and the move assignment operator, which might have a serious performance impact. --- pdns/dns.hh | 1 - 1 file changed, 1 deletion(-) diff --git a/pdns/dns.hh b/pdns/dns.hh index adc8536dbe..8a138476cb 100644 --- a/pdns/dns.hh +++ b/pdns/dns.hh @@ -82,7 +82,6 @@ class DNSResourceRecord { public: DNSResourceRecord() : last_modified(0), ttl(0), signttl(0), domain_id(-1), qclass(1), scopeMask(0), auth(1), disabled(0) {}; - ~DNSResourceRecord(){}; static DNSResourceRecord fromWire(const DNSRecord& d); enum Place : uint8_t {QUESTION=0, ANSWER=1, AUTHORITY=2, ADDITIONAL=3}; //!< Type describing the positioning within, say, a DNSPacket -- 2.47.2