From 9b7dc1d77a4fc990dc8f91f5e8355491e14acc36 Mon Sep 17 00:00:00 2001 From: Otto Moerbeek Date: Mon, 9 Nov 2020 12:38:14 +0100 Subject: [PATCH] x-our-latency is a gauge. While there, describe better what it is and fix a ref. Fixes #9638 --- pdns/recursordist/docs/metrics.rst | 4 ++-- pdns/recursordist/rec_metrics.hh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pdns/recursordist/docs/metrics.rst b/pdns/recursordist/docs/metrics.rst index d65b7557f8..beebdfe991 100644 --- a/pdns/recursordist/docs/metrics.rst +++ b/pdns/recursordist/docs/metrics.rst @@ -540,8 +540,6 @@ user-msec ^^^^^^^^^ number of CPU milliseconds spent in 'user' mode -.. _stat-x-our-latency: - variable-responses ^^^^^^^^^^^^^^^^^^ .. versionadded:: 4.2 @@ -550,6 +548,8 @@ Responses that were marked as 'variable'. This could be because of EDNS Client Subnet or Lua rules that indicate this variable status (dependent on time or who is asking, for example). +.. _stat-x-our-latency: + x-our-latency ^^^^^^^^^^^^^ .. versionadded:: 4.1 diff --git a/pdns/recursordist/rec_metrics.hh b/pdns/recursordist/rec_metrics.hh index 4cc6b4a125..4a0be9e394 100644 --- a/pdns/recursordist/rec_metrics.hh +++ b/pdns/recursordist/rec_metrics.hh @@ -399,8 +399,8 @@ private: "Number of responses that were marked as 'variable'")}, {"x-our-latency", - MetricDefinition(PrometheusMetricType::counter, - "How much time was spent within PowerDNS in microseconds")}, + MetricDefinition(PrometheusMetricType::gauge, + "Shows the averaged time spent within PowerDNS, in microseconds, exponentially weighted over past 'latency-statistic-size' packets")}, {"x-ourtime0-1", MetricDefinition(PrometheusMetricType::counter, "Counts responses where between 0 and 1 milliseconds was spent within the Recursor")}, -- 2.47.2