From 7adba5554030d086ec636f8b6bec7f86269258af Mon Sep 17 00:00:00 2001 From: Otto Date: Mon, 11 Jan 2021 15:01:18 +0100 Subject: [PATCH] CodeQL: two instances of expressions being always true --- pdns/dnsdist-lua-actions.cc | 2 +- pdns/ssqlite3.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pdns/dnsdist-lua-actions.cc b/pdns/dnsdist-lua-actions.cc index 9102feac4d..45fa666337 100644 --- a/pdns/dnsdist-lua-actions.cc +++ b/pdns/dnsdist-lua-actions.cc @@ -237,7 +237,7 @@ void TeeAction::worker() res=recv(d_fd, packet, sizeof(packet), 0); if(res <= (int)sizeof(struct dnsheader)) d_recverrors++; - else if(res > 0) + else d_responses++; if(dh->rcode == RCode::NoError) diff --git a/pdns/ssqlite3.cc b/pdns/ssqlite3.cc index 8fc9466a43..8602f162ff 100644 --- a/pdns/ssqlite3.cc +++ b/pdns/ssqlite3.cc @@ -216,7 +216,7 @@ void SSQLite3::setLog(bool state) SSQLite3::~SSQLite3() { int ret; - for(int n = 0; n < 2 ; ++n) { + for(int n = 0; ; ++n) { if((ret =sqlite3_close( m_pDB )) != SQLITE_OK) { if(n || ret != SQLITE_BUSY) { // if we have SQLITE_BUSY, and a working m_Pstmt, try finalize cerr<<"Unable to close down sqlite connection: "<