From d9abac54ffcb975a4259b15f9f6fca3d6d0e3569 Mon Sep 17 00:00:00 2001 From: Otto Date: Mon, 11 Jan 2021 16:21:03 +0100 Subject: [PATCH] Bunch of signed vs unsigned warnings --- pdns/calidns.cc | 2 +- pdns/recursordist/test-syncres_cc7.cc | 4 ++-- pdns/test-dnsdist_cc.cc | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pdns/calidns.cc b/pdns/calidns.cc index d07ac19f4a..df93077981 100644 --- a/pdns/calidns.cc +++ b/pdns/calidns.cc @@ -108,7 +108,7 @@ static void* recvThread(const vector>* sockets) continue; } g_recvcounter++; - for (unsigned int i = 0; i < buf.msg_iovlen; i++) + for (int i = 0; i < buf.msg_iovlen; i++) g_recvbytes += buf.msg_iov[i].iov_len; #endif } diff --git a/pdns/recursordist/test-syncres_cc7.cc b/pdns/recursordist/test-syncres_cc7.cc index d1341945e0..4641f96b7f 100644 --- a/pdns/recursordist/test-syncres_cc7.cc +++ b/pdns/recursordist/test-syncres_cc7.cc @@ -1583,7 +1583,7 @@ BOOST_AUTO_TEST_CASE(test_dnssec_secure_to_insecure_cut_with_cname_at_apex) BOOST_CHECK_EQUAL(queriesCount, 11U); /* now we remove the denial of powerdns.com DS from the cache and ask www2 */ - BOOST_REQUIRE_EQUAL(g_negCache->wipe(target, false), 1); + BOOST_REQUIRE_EQUAL(g_negCache->wipe(target, false), 1U); ret.clear(); res = sr->beginResolve(DNSName("www2.powerdns.com."), QType(QType::A), QClass::IN, ret); BOOST_CHECK_EQUAL(res, RCode::NoError); @@ -1706,7 +1706,7 @@ BOOST_AUTO_TEST_CASE(test_dnssec_cname_inside_secure_zone) BOOST_CHECK_EQUAL(queriesCount, 10U); /* now we remove the denial of powerdns.com DS from the cache and ask www2 */ - BOOST_REQUIRE_EQUAL(g_negCache->wipe(target, false), 1); + BOOST_REQUIRE_EQUAL(g_negCache->wipe(target, false), 1U); ret.clear(); res = sr->beginResolve(DNSName("www2.powerdns.com."), QType(QType::A), QClass::IN, ret); BOOST_CHECK_EQUAL(res, RCode::NoError); diff --git a/pdns/test-dnsdist_cc.cc b/pdns/test-dnsdist_cc.cc index f17e399281..638c74a735 100644 --- a/pdns/test-dnsdist_cc.cc +++ b/pdns/test-dnsdist_cc.cc @@ -135,7 +135,7 @@ BOOST_AUTO_TEST_CASE(test_addXPF) DNSQuestion dq(&qname, qtype, QClass::IN, &remote, &remote, packet, false, &queryTime); BOOST_REQUIRE(!addXPF(dq, xpfOptionCode)); - BOOST_CHECK_EQUAL(packet.size(), 4096); + BOOST_CHECK_EQUAL(packet.size(), 4096U); packet.resize(query.size()); validateQuery(packet, false, false); } @@ -286,7 +286,7 @@ BOOST_AUTO_TEST_CASE(addECSWithoutEDNSAlreadyParsed) BOOST_CHECK(handleEDNSClientSubnet(dq2, ednsAdded, ecsAdded)); BOOST_CHECK_GT(packet.size(), query.size()); - BOOST_CHECK_LT(packet.size(), 2048); + BOOST_CHECK_LT(packet.size(), 2048U); BOOST_CHECK_EQUAL(ednsAdded, true); BOOST_CHECK_EQUAL(ecsAdded, true); validateQuery(packet); @@ -387,7 +387,7 @@ BOOST_AUTO_TEST_CASE(addECSWithEDNSNoECSAlreadyParsed) { BOOST_CHECK(handleEDNSClientSubnet(dq2, ednsAdded, ecsAdded)); BOOST_CHECK_GT(packet.size(), query.size()); - BOOST_CHECK_LT(packet.size(), 2048); + BOOST_CHECK_LT(packet.size(), 2048U); BOOST_CHECK_EQUAL(ednsAdded, false); BOOST_CHECK_EQUAL(ecsAdded, true); validateQuery(packet); -- 2.47.2