From 8c47b5d52ff067ebfef05ce9f3470b96579de1a5 Mon Sep 17 00:00:00 2001 From: Gary Lockyer Date: Fri, 1 Aug 2025 07:58:52 +1200 Subject: [PATCH] librpc:ndr:keycredlink fix CID 1660828 Fixes: *** CID 1660828: Control flow issues (UNREACHABLE) /librpc/ndr/ndr_keycredlink.c: 752 in pull_DER_RSA_KEY() 746 goto out; 747 } 748 if (!asn1_end_tag(asn)) { /* PublicKeyInfo */ 749 return ndr_pull_error(ndr, 750 NDR_ERR_UNREAD_BYTES, 751 "ASN1 element PublicKeyInfo"); >>> CID 1660828: Control flow issues (UNREACHABLE) >>> This code cannot be reached: "goto out;". 752 goto out; 753 } Signed-off-by: Gary Lockyer Reviewed-by: Douglas Bagnall Reviewed-by: Anoop C S Autobuild-User(master): Anoop C S Autobuild-Date(master): Fri Aug 1 14:21:17 UTC 2025 on atb-devel-224 --- librpc/ndr/ndr_keycredlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/librpc/ndr/ndr_keycredlink.c b/librpc/ndr/ndr_keycredlink.c index 2222e3bf666..286236060c4 100644 --- a/librpc/ndr/ndr_keycredlink.c +++ b/librpc/ndr/ndr_keycredlink.c @@ -746,9 +746,9 @@ static enum ndr_err_code pull_DER_RSA_KEY(struct ndr_pull *ndr, goto out; } if (!asn1_end_tag(asn)) { /* PublicKeyInfo */ - return ndr_pull_error(ndr, - NDR_ERR_UNREAD_BYTES, - "ASN1 element PublicKeyInfo"); + ret = ndr_pull_error(ndr, + NDR_ERR_UNREAD_BYTES, + "ASN1 element PublicKeyInfo"); goto out; } -- 2.47.2