From 1b5a9a7d569a246c46537ba4bb2b5edc6463e784 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Sun, 19 Oct 2025 21:26:48 +0200 Subject: [PATCH] core/service: avoid duplicate unit_add_to_dbus_queue() call If we're changing state anyways, service_set_state() -> unit_notify() will take care of dbus signaling for us. --- src/core/service.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/core/service.c b/src/core/service.c index df89534a452..49c4b52af18 100644 --- a/src/core/service.c +++ b/src/core/service.c @@ -4806,8 +4806,6 @@ static void service_notify_message( if (IN_SET(s->state, SERVICE_RUNNING, SERVICE_RELOAD_SIGNAL, SERVICE_RELOAD_NOTIFY, SERVICE_REFRESH_EXTENSIONS)) service_enter_stop_by_notify(s); - notify_dbus = true; - } else if (strv_contains(tags, "READY=1")) { s->notify_state = NOTIFY_READY; @@ -4842,8 +4840,6 @@ static void service_notify_message( if (s->state == SERVICE_RELOAD_NOTIFY) service_enter_running(s, SERVICE_SUCCESS); - notify_dbus = true; - } else if (strv_contains(tags, "RELOADING=1")) { s->notify_state = NOTIFY_RELOADING; @@ -4861,8 +4857,6 @@ static void service_notify_message( if (s->state == SERVICE_RUNNING) service_enter_reload_by_notify(s); - - notify_dbus = true; } /* Interpret STATUS= */ -- 2.47.3