From 9b6f3be2fb8d81d664dd94f08070bfe78658b67d Mon Sep 17 00:00:00 2001 From: Joshua Rogers Date: Sat, 6 Sep 2025 12:34:22 +0000 Subject: [PATCH] ext_kerberos_ldap_group_acl: Improve LDAPMessage freeing (#2181) Do not free uninitialized or freed LDAPMessage. --- src/acl/external/kerberos_ldap_group/support_ldap.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/acl/external/kerberos_ldap_group/support_ldap.cc b/src/acl/external/kerberos_ldap_group/support_ldap.cc index 20011f1543..94787497b5 100644 --- a/src/acl/external/kerberos_ldap_group/support_ldap.cc +++ b/src/acl/external/kerberos_ldap_group/support_ldap.cc @@ -298,7 +298,7 @@ escape_filter(char *filter) int check_AD(struct main_args *margs, LDAP * ld) { - LDAPMessage *res; + LDAPMessage *res = nullptr; char **attr_value = nullptr; struct timeval searchtime; size_t max_attr = 0; @@ -322,6 +322,7 @@ check_AD(struct main_args *margs, LDAP * ld) if (max_attr == 1) { ldap_msgfree(res); + res = nullptr; debug((char *) "%s| %s: DEBUG: Search ldap server with bind path %s and filter: %s\n", LogTime(), PROGRAM, attr_value[0], FILTER_SAM); @@ -350,6 +351,7 @@ check_AD(struct main_args *margs, LDAP * ld) safe_free(attr_value); } ldap_msgfree(res); + res = nullptr; return rc; } -- 2.47.3