From 36debf3ccfa33ea9f3b0e562a133a22d1bdc87bd Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Fri, 27 Jun 2025 18:59:23 +0200 Subject: [PATCH] tests/unit/test_xaprintf.c: Fix test by using streq() instead of strcmp(3) Fixes: 423fd652b563 (2025-06-03; "lib/string/sprintf/, tests/unit/: Transform x[v]asprintf() into x[v]aprintf()") Closes: Reported-by: Timo Gurr Signed-off-by: Alejandro Colomar --- tests/unit/Makefile.am | 1 + tests/unit/test_xaprintf.c | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/unit/Makefile.am b/tests/unit/Makefile.am index 6e943183b..64470f462 100644 --- a/tests/unit/Makefile.am +++ b/tests/unit/Makefile.am @@ -132,6 +132,7 @@ test_typetraits_LDADD = \ test_xaprintf_SOURCES = \ ../../lib/string/sprintf/aprintf.c \ ../../lib/string/sprintf/xaprintf.c \ + ../../lib/string/strcmp/streq.c \ test_xaprintf.c \ $(NULL) test_xaprintf_CFLAGS = \ diff --git a/tests/unit/test_xaprintf.c b/tests/unit/test_xaprintf.c index 156528a17..d66fa67f8 100644 --- a/tests/unit/test_xaprintf.c +++ b/tests/unit/test_xaprintf.c @@ -2,6 +2,8 @@ // SPDX-License-Identifier: BSD-3-Clause +#include "string/sprintf/xaprintf.h" + #include #include #include @@ -14,7 +16,7 @@ #include // Required by #include -#include "string/sprintf/xaprintf.h" +#include "string/strcmp/streq.h" #define smock() _Generic(mock(), uintmax_t: (intmax_t) mock()) @@ -76,7 +78,7 @@ test_xaprintf_exit(void **state) assert_unreachable(); break; case EXIT_CALLED: - assert_true(strcmp(p, "xaprintf_called")); + assert_true(streq(p, "xaprintf_called")); p = "test_ok"; break; default: @@ -84,7 +86,7 @@ test_xaprintf_exit(void **state) break; } - assert_true(strcmp(p, "test_ok")); + assert_true(streq(p, "test_ok")); } -- 2.39.5