zoneedit.com: Provider do not use the DynDNS2 protocol.

[ddns.git] / src / ddns / providers.py

diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 16a6e7b84a12e61626daae02114dfa88fa168690..0f873438e1ff5b0e7b54697ed8f70a881fefbeee 100644 (file)
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -223,6 +223,14 @@ class DDNSProvider(object):
                if not last_status == "failure":
                        return False
 
+               # If there is no holdoff time, we won't update ever again.
+               if self.holdoff_failure_days is None:
+                       logger.warning(_("An update has not been performed because earlier updates failed for %s") \
+                               % self.hostname)
+                       logger.warning(_("There will be no retries"))
+
+                       return True
+
                # Determine when the holdoff time ends
                last_update = self.db.last_update(self.hostname, status=last_status)
                holdoff_end = last_update + datetime.timedelta(days=self.holdoff_failure_days)
@@ -1051,6 +1059,10 @@ class DDNSProviderNsupdateINFO(DDNSProtocolDynDNS2, DDNSProvider):
        # has not been implemented here, yet.
        can_remove_records = False
 
+       # After a failed update, there will be no retries
+       # https://bugzilla.ipfire.org/show_bug.cgi?id=10603
+       holdoff_failure_days = None
+
        # Nsupdate.info uses the hostname as user part for the HTTP basic auth,
        # and for the password a so called secret.
        @property
@@ -1291,7 +1303,7 @@ class DDNSProviderVariomedia(DDNSProtocolDynDNS2, DDNSProvider):
                return data
 
 
-class DDNSProviderZoneedit(DDNSProtocolDynDNS2, DDNSProvider):
+class DDNSProviderZoneedit(DDNSProvider):
        handle    = "zoneedit.com"
        name      = "Zoneedit"
        website   = "http://www.zoneedit.com"