Merge remote-tracking branch 'amarx/firewall-dnat' into next

[ipfire-2.x.git] / config / firewall / rules.pl

diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
index 887c0526575ed9713a9f399ad623cfcee611ec8d..e0f69554e847d7949fc28b50e657d1cf6101ed9e 100755 (executable)
--- a/config/firewall/rules.pl
+++ b/config/firewall/rules.pl
@@ -291,7 +291,8 @@ sub buildrules {
 
                        foreach my $src (@sources) {
                                # Skip invalid source.
-                               next unless (@$src[0]);
+                               next unless (defined $src);
+                               next unless ($src);
 
                                # Sanitize source.
                                my $source = @$src[0];
@@ -303,7 +304,8 @@ sub buildrules {
 
                                foreach my $dst (@destinations) {
                                        # Skip invalid rules.
-                                       next if (!@$dst[0] || (@$dst[0] eq "none"));
+                                       next unless (defined $dst);
+                                       next if (!$dst || ($dst eq "none"));
 
                                        # Sanitize destination.
                                        my $destination = @$dst[0];