]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
services.cgi: Fix wrong memory usage display.
authorMichael Tremer <michael.tremer@ipfire.org>
Thu, 19 Jul 2012 20:12:05 +0000 (22:12 +0200)
committerMichael Tremer <michael.tremer@ipfire.org>
Thu, 19 Jul 2012 20:12:05 +0000 (22:12 +0200)
config/rootfiles/core/61/filelists/files
html/cgi-bin/services.cgi

index 1466fef82ec254c0e90e60e79cbf3db09c14e255..6ef00dc60afcb1d4180dfb4320569578f2ee8a1a 100644 (file)
@@ -6,6 +6,7 @@ srv/web/ipfire/cgi-bin/index.cgi
 srv/web/ipfire/cgi-bin/connections.cgi
 srv/web/ipfire/cgi-bin/ovpnmain.cgi
 srv/web/ipfire/cgi-bin/proxy.cgi
+srv/web/ipfire/cgi-bin/services.cgi
 var/ipfire/general-functions.pl
 var/ipfire/langs
 var/ipfire/proxy/calamaris/bin/mkreport
index 55740cf26dbd56b3bb20234329e6206465cdd473..123c3258792ddab8da3350c2c9600dca3132d483 100644 (file)
@@ -240,7 +240,7 @@ sub isrunning{
        my $pid = '';
        my $testcmd = '';
        my $exename;
-       my @memory;
+       my $memory;
 
        $cmd =~ /(^[a-z]+)/;
        $exename = $1;
@@ -256,13 +256,18 @@ sub isrunning{
                        }
                        close FILE;
                }
-               if (open(FILE, "/proc/${pid}/statm")){
-                               my $temp = <FILE>;
-                               @memory = split(/ /,$temp);
+               if (open(FILE, "/proc/${pid}/status")) {
+                       while (<FILE>) {
+                               my ($key, $val) = split(":", $_, 2);
+                               if ($key eq 'VmRSS') {
+                                       $memory = $val;
+                                       last;
+                               }
+                       }
+                       close(FILE);
                }
-               close FILE;
                if ($testcmd =~ /$exename/){
-                       $status = "<td align='center' bgcolor='${Header::colourgreen}'><font color='white'><b>$Lang::tr{'running'}</b></font></td><td align='center'>$pid</td><td align='center'>$memory[0] KB</td>";
+                       $status = "<td align='center' bgcolor='${Header::colourgreen}'><font color='white'><b>$Lang::tr{'running'}</b></font></td><td align='center'>$pid</td><td align='center'>$memory</td>";
                }
        }
        return $status;