From: Erik Kapfer <erik.kapfer@ipfire.org>
Date: Mon, 18 Jun 2018 15:32:57 +0000 (+0200)
Subject: OpenVPN: Prevent that a Roadwarrior name will be set two times
X-Git-Tag: v2.21-core123~136
X-Git-Url: http://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff_plain;h=beac479f2d1f4ad3e758df2346b6d5f0334458ea

OpenVPN: Prevent that a Roadwarrior name will be set two times

Fixes bug #11307

Signed-off-by: Erik Kapfer <erik.kapfer@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 947cbe9e7c..0bc28cefea 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -4180,6 +4180,16 @@ if ($cgiparams{'TYPE'} eq 'net') {
 		}
 	    }
 
+		# Check for RW if client name is already set
+		if ($cgiparams{'TYPE'} eq 'host') {
+			foreach my $key (keys %confighash) {
+				if ($confighash{$key}[1] eq $cgiparams{'NAME'}) {
+					$errormessage = $Lang::tr{'a connection with this name already exists'};
+					goto VPNCONF_ERROR;
+				}
+			}
+		}
+
 	    # Replace empty strings with a .
 	    (my $ou = $cgiparams{'CERT_OU'}) =~ s/^\s*$/\./;
 	    (my $city = $cgiparams{'CERT_CITY'}) =~ s/^\s*$/\./;