]> git.ipfire.org Git - ipfire.org.git/blob - src/scss/bootstrap-4.0.0-alpha.6/CONTRIBUTING.md
.gitignore: Add .vscode
[ipfire.org.git] / src / scss / bootstrap-4.0.0-alpha.6 / CONTRIBUTING.md
1 # Contributing to Bootstrap
2
3 Looking to contribute something to Bootstrap? **Here's how you can help.**
4
5 Please take a moment to review this document in order to make the contribution
6 process easy and effective for everyone involved.
7
8 Following these guidelines helps to communicate that you respect the time of
9 the developers managing and developing this open source project. In return,
10 they should reciprocate that respect in addressing your issue or assessing
11 patches and features.
12
13
14 ## Using the issue tracker
15
16 The [issue tracker](https://github.com/twbs/bootstrap/issues) is
17 the preferred channel for [bug reports](#bug-reports), [features requests](#feature-requests)
18 and [submitting pull requests](#pull-requests), but please respect the following
19 restrictions:
20
21 * Please **do not** use the issue tracker for personal support requests. Stack
22 Overflow ([`bootstrap-4`](https://stackoverflow.com/questions/tagged/bootstrap-4) tag), [Slack](https://bootstrap-slack.herokuapp.com/) or [IRC](README.md#community) are better places to get help.
23
24 * Please **do not** derail or troll issues. Keep the discussion on topic and
25 respect the opinions of others.
26
27 * Please **do not** post comments consisting solely of "+1" or ":thumbsup:".
28 Use [GitHub's "reactions" feature](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments)
29 instead. We reserve the right to delete comments which violate this rule.
30
31 * Please **do not** open issues or pull requests regarding the code in
32 [`Normalize`](https://github.com/necolas/normalize.css) (open them in
33 its repository).
34
35 * Please **do not** open issues regarding the official themes offered on <https://themes.getbootstrap.com/>.
36 Instead, please email any questions or feedback regarding those themes to `themes AT getbootstrap DOT com`.
37
38
39 ## Issues and labels
40
41 Our bug tracker utilizes several labels to help organize and identify issues. Here's what they represent and how we use them:
42
43 - `browser bug` - Issues that are reported to us, but actually are the result of a browser-specific bug. These are diagnosed with reduced test cases and result in an issue opened on that browser's own bug tracker.
44 - `confirmed` - Issues that have been confirmed with a reduced test case and identify a bug in Bootstrap.
45 - `css` - Issues stemming from our compiled CSS or source Sass files.
46 - `docs` - Issues for improving or updating our documentation.
47 - `examples` - Issues involving the example templates included in our docs.
48 - `feature` - Issues asking for a new feature to be added, or an existing one to be extended or modified. New features require a minor version bump (e.g., `v3.0.0` to `v3.1.0`).
49 - `grunt` - Issues with our included JavaScript-based Gruntfile, which is used to run all our tests, concatenate and compile source files, and more.
50 - `help wanted` - Issues we need or would love help from the community to resolve.
51 - `js` - Issues stemming from our compiled or source JavaScript files.
52 - `meta` - Issues with the project itself or our GitHub repository.
53
54 For a complete look at our labels, see the [project labels page](https://github.com/twbs/bootstrap/labels).
55
56
57 ## Bug reports
58
59 A bug is a _demonstrable problem_ that is caused by the code in the repository.
60 Good bug reports are extremely helpful, so thanks!
61
62 Guidelines for bug reports:
63
64 0. **Validate and lint your code** &mdash; [validate your HTML](https://html5.validator.nu)
65 and [lint your HTML](https://github.com/twbs/bootlint) to ensure your
66 problem isn't caused by a simple error in your own code.
67
68 1. **Use the GitHub issue search** &mdash; check if the issue has already been
69 reported.
70
71 2. **Check if the issue has been fixed** &mdash; try to reproduce it using the
72 latest `master` or development branch in the repository.
73
74 3. **Isolate the problem** &mdash; ideally create a [reduced test
75 case](https://css-tricks.com/reduced-test-cases/) and a live example.
76 [This JS Bin](https://jsbin.com/lolome/edit?html,output) is a helpful template.
77
78
79 A good bug report shouldn't leave others needing to chase you up for more
80 information. Please try to be as detailed as possible in your report. What is
81 your environment? What steps will reproduce the issue? What browser(s) and OS
82 experience the problem? Do other browsers show the bug differently? What
83 would you expect to be the outcome? All these details will help people to fix
84 any potential bugs.
85
86 Example:
87
88 > Short and descriptive example bug report title
89 >
90 > A summary of the issue and the browser/OS environment in which it occurs. If
91 > suitable, include the steps required to reproduce the bug.
92 >
93 > 1. This is the first step
94 > 2. This is the second step
95 > 3. Further steps, etc.
96 >
97 > `<url>` - a link to the reduced test case
98 >
99 > Any other information you want to share that is relevant to the issue being
100 > reported. This might include the lines of code that you have identified as
101 > causing the bug, and potential solutions (and your opinions on their
102 > merits).
103
104 ### Reporting upstream browser bugs
105
106 Sometimes bugs reported to us are actually caused by bugs in the browser(s) themselves, not bugs in Bootstrap per se.
107 When feasible, we aim to report such upstream bugs to the relevant browser vendor(s), and then list them on our [Wall of Browser Bugs](https://getbootstrap.com/browser-bugs/) and [document them in MDN](https://developer.mozilla.org/en-US/docs/Web).
108
109 | Vendor(s) | Browser(s) | Rendering engine | Bug reporting website(s) | Notes |
110 | ------------- | ---------------------------- | ---------------- | ------------------------------------------------------------------------------------- | -------------------------------------------------------- |
111 | Mozilla | Firefox | Gecko | https://bugzilla.mozilla.org/enter_bug.cgi | "Core" is normally the right product option to choose. |
112 | Apple | Safari | WebKit | https://bugs.webkit.org/enter_bug.cgi?product=WebKit <br> https://bugreport.apple.com | In Apple's bug reporter, choose "Safari" as the product. |
113 | Google, Opera | Chrome, Chromium, Opera v15+ | Blink | https://code.google.com/p/chromium/issues/list | Click the "New issue" button. |
114 | Microsoft | Edge | EdgeHTML | https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/ | |
115
116 ### Issues bots
117
118 [@twbs-lmvtfy](https://github.com/twbs-lmvtfy) is a Bootstrap bot that hangs out in our GitHub issue tracker and automatically checks for HTML validation errors in live examples (e.g. jsFiddles, JS Bins, Bootplys, Plunks, CodePens, etc.) posted in issue comments. If it finds any errors, it will post a follow-up comment on the issue and point out the errors. If this happens with an example you've posted, please fix the errors and post an updated live example. If you opened a bug report, please check whether the bug still occurs with your revised, valid live example. If the bug no longer occurs, it was probably due to your invalid HTML rather than something in Bootstrap and we'd appreciate it if you could close out the GitHub issue.
119
120
121 ## Feature requests
122
123 Feature requests are welcome. But take a moment to find out whether your idea
124 fits with the scope and aims of the project. It's up to *you* to make a strong
125 case to convince the project's developers of the merits of this feature. Please
126 provide as much detail and context as possible.
127
128
129 ## Pull requests
130
131 Good pull requests—patches, improvements, new features—are a fantastic
132 help. They should remain focused in scope and avoid containing unrelated
133 commits.
134
135 **Please ask first** before embarking on any significant pull request (e.g.
136 implementing features, refactoring code, porting to a different language),
137 otherwise you risk spending a lot of time working on something that the
138 project's developers might not want to merge into the project.
139
140 Please adhere to the [coding guidelines](#code-guidelines) used throughout the
141 project (indentation, accurate comments, etc.) and any other requirements
142 (such as test coverage).
143
144 **Do not edit `bootstrap.css`, or `bootstrap.js`
145 directly!** Those files are automatically generated. You should edit the
146 source files in [`/bootstrap/scss/`](https://github.com/twbs/bootstrap/tree/master/scss)
147 and/or [`/bootstrap/js/`](https://github.com/twbs/bootstrap/tree/master/js) instead.
148
149 Similarly, when contributing to Bootstrap's documentation, you should edit the
150 documentation source files in
151 [the `/bootstrap/docs/` directory of the `master` branch](https://github.com/twbs/bootstrap/tree/master/docs).
152 **Do not edit the `gh-pages` branch.** That branch is generated from the
153 documentation source files and is managed separately by the Bootstrap Core Team.
154
155 Adhering to the following process is the best way to get your work
156 included in the project:
157
158 1. [Fork](https://help.github.com/fork-a-repo/) the project, clone your fork,
159 and configure the remotes:
160
161 ```bash
162 # Clone your fork of the repo into the current directory
163 git clone https://github.com/<your-username>/bootstrap.git
164 # Navigate to the newly cloned directory
165 cd bootstrap
166 # Assign the original repo to a remote called "upstream"
167 git remote add upstream https://github.com/twbs/bootstrap.git
168 ```
169
170 2. If you cloned a while ago, get the latest changes from upstream:
171
172 ```bash
173 git checkout master
174 git pull upstream master
175 ```
176
177 3. Create a new topic branch (off the main project development branch) to
178 contain your feature, change, or fix:
179
180 ```bash
181 git checkout -b <topic-branch-name>
182 ```
183
184 4. Commit your changes in logical chunks. Please adhere to these [git commit
185 message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
186 or your code is unlikely be merged into the main project. Use Git's
187 [interactive rebase](https://help.github.com/articles/interactive-rebase)
188 feature to tidy up your commits before making them public.
189
190 5. Locally merge (or rebase) the upstream development branch into your topic branch:
191
192 ```bash
193 git pull [--rebase] upstream master
194 ```
195
196 6. Push your topic branch up to your fork:
197
198 ```bash
199 git push origin <topic-branch-name>
200 ```
201
202 7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
203 with a clear title and description against the `master` branch.
204
205 **IMPORTANT**: By submitting a patch, you agree to allow the project owners to
206 license your work under the terms of the [MIT License](LICENSE) (if it
207 includes code changes) and under the terms of the
208 [Creative Commons Attribution 3.0 Unported License](docs/LICENSE)
209 (if it includes documentation changes).
210
211 ### Pull request bots
212
213 [@twbs-rorschach](https://github.com/twbs-rorschach) is a Bootstrap bot that hangs out in our GitHub issue tracker and automatically checks all pull requests for a few simple common mistakes. It's possible that Rorschach might leave a comment on your pull request and then close it. If that happens, simply fix the problem(s) mentioned in the comment (there should be link(s) in the comment explaining the problem(s) in detail) and then either:
214
215 * Push the revised version to your pull request's branch and post a comment on the pull request saying that you've fixed the problem(s). One of the Bootstrap Core Team members will then come along and reopen your pull request.
216 * Or you can just open a new pull request for your revised version.
217
218 [@twbs-savage](https://github.com/twbs-savage) is a Bootstrap bot that automatically runs cross-browser tests (via [Sauce](https://saucelabs.com) and Travis CI) on JavaScript pull requests. Savage will leave a comment on pull requests stating whether cross-browser JS tests passed or failed, with a link to the full Travis build details. If your pull request fails, check the Travis log to see which browser + OS combinations failed. Each browser test in the Travis log includes a link to a Sauce page with details about the test. On those details pages, you can watch a screencast of the test run to see exactly which unit tests failed.
219
220
221 ## Code guidelines
222
223 ### HTML
224
225 [Adhere to the Code Guide.](http://codeguide.co/#html)
226
227 - Use tags and elements appropriate for an HTML5 doctype (e.g., self-closing tags).
228 - Use CDNs and HTTPS for third-party JS when possible. We don't use protocol-relative URLs in this case because they break when viewing the page locally via `file://`.
229 - Use [WAI-ARIA](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA) attributes in documentation examples to promote accessibility.
230
231 ### CSS
232
233 [Adhere to the Code Guide.](http://codeguide.co/#css)
234
235 - When feasible, default color palettes should comply with [WCAG color contrast guidelines](https://www.w3.org/TR/WCAG20/#visual-audio-contrast).
236 - Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](http://a11yproject.com/posts/never-remove-css-outlines/) for more details.
237
238 ### JS
239
240 - No semicolons (in client-side JS)
241 - 2 spaces (no tabs)
242 - strict mode
243 - "Attractive"
244 - Don't use [jQuery event alias convenience methods](https://github.com/jquery/jquery/blob/master/src/event/alias.js) (such as `$().focus()`). Instead, use [`$().trigger(eventType, ...)`](https://api.jquery.com/trigger/) or [`$().on(eventType, ...)`](https://api.jquery.com/on/), depending on whether you're firing an event or listening for an event. (For example, `$().trigger('focus')` or `$().on('focus', function (event) { /* handle focus event */ })`) We do this to be compatible with custom builds of jQuery where the event aliases module has been excluded.
245
246 ### Checking coding style
247
248 Run `grunt test` before committing to ensure your changes follow our coding standards.
249
250
251 ## License
252
253 By contributing your code, you agree to license your contribution under the [MIT License](LICENSE).
254 By contributing to the documentation, you agree to license your contribution under the [Creative Commons Attribution 3.0 Unported License](docs/LICENSE).
255
256 Prior to v3.1.0, Bootstrap's code was released under the Apache License v2.0.