X-Git-Url: http://git.ipfire.org/?p=oddments%2Fddns.git;a=blobdiff_plain;f=src%2Fddns%2Fproviders.py;h=8576c9bccae0838c991478c83b406d079adc56d3;hp=5ff0631daeba8fcae6bf9a681b74fc1ab851ac7d;hb=4caed6ed57ba0c86e11c81f218b10efc9bf6a301;hpb=39301272d21797e2ce427b5afecc9b086a22ff4b

diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 5ff0631..8576c9b 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -19,9 +19,16 @@
 #                                                                             #
 ###############################################################################
 
+import logging
+
+from i18n import _
+
 # Import all possible exception types.
 from .errors import *
 
+logger = logging.getLogger("ddns.providers")
+logger.propagate = 1
+
 class DDNSProvider(object):
 	INFO = {
 		# A short string that uniquely identifies
@@ -104,9 +111,41 @@ class DDNSProvider(object):
 		"""
 		return self.get("password")
 
-	def __call__(self):
+	@property
+	def protocols(self):
+		return self.INFO.get("protocols")
+
+	def __call__(self, force=False):
+		if force:
+			logger.info(_("Updating %s forced") % self.hostname)
+
+		# Check if we actually need to update this host.
+		elif self.is_uptodate(self.protocols):
+			logger.info(_("%s is already up to date") % self.hostname)
+			return
+
+		# Execute the update.
+		self.update()
+
+	def update(self):
 		raise NotImplementedError
 
+	def is_uptodate(self, protos):
+		"""
+			Returns True if this host is already up to date
+			and does not need to change the IP address on the
+			name server.
+		"""
+		for proto in protos:
+			addresses = self.core.system.resolve(self.hostname, proto)
+
+			current_address = self.get_address(proto)
+
+			if not current_address in addresses:
+				return False
+
+		return True
+
 	def send_request(self, *args, **kwargs):
 		"""
 			Proxy connection to the send request
@@ -133,7 +172,7 @@ class DDNSProviderDHS(DDNSProvider):
 	# grabed from source code of ez-ipudate.
 	url = "http://members.dhs.org/nic/hosts"
 
-	def __call__(self):
+	def update(self):
 		url = self.url % {
 			"username" : self.username,
 			"password" : self.password,
@@ -156,7 +195,7 @@ class DDNSProviderDHS(DDNSProvider):
 			return
 
 		# Handle error codes.
-		elif response.code == "401":
+		elif response.code == 401:
 			raise DDNSAuthenticationError
 
 		# If we got here, some other update error happened.
@@ -175,7 +214,7 @@ class DDNSProviderDNSpark(DDNSProvider):
 	# https://dnspark.zendesk.com/entries/31229348-Dynamic-DNS-API-Documentation
 	url = "https://control.dnspark.com/api/dynamic/update.php"
 
-	def __call__(self):
+	def update(self):
 		url = self.url % {
 			"username" : self.username,
 			"password" : self.password,
@@ -236,7 +275,7 @@ class DDNSProviderLightningWireLabs(DDNSProvider):
 		"""
 		return self.get("token")
 
-	def __call__(self):
+	def update(self):
 		data =  {
 			"hostname" : self.hostname,
 		}
@@ -271,16 +310,16 @@ class DDNSProviderLightningWireLabs(DDNSProvider):
 			raise DDNSConfigurationError
 
 		# Send update to the server.
-		response = self.send_request(url, data=data)
+		response = self.send_request(self.url, data=data)
 
 		# Handle success messages.
 		if response.code == 200:
 			return
 
 		# Handle error codes.
-		if response.code == "403":
+		if response.code == 403:
 			raise DDNSAuthenticationError
-		elif response.code == "400":
+		elif response.code == 400:
 			raise DDNSRequestError
 
 		# If we got here, some other update error happened.
@@ -301,7 +340,7 @@ class DDNSProviderNOIP(DDNSProvider):
 
 	url = "http://%(username)s:%(password)s@dynupdate.no-ip.com/nic/update"
 
-	def __call__(self):
+	def update(self):
 		url = self.url % {
 			"username" : self.username,
 			"password" : self.password,
@@ -344,7 +383,7 @@ class DDNSProviderSelfhost(DDNSProvider):
 
 	url = "https://carol.selfhost.de/update"
 
-	def __call__(self):
+	def update(self):
 		data = {
 			"username" : self.username,
 			"password" : self.password,