compress: Remove legacy logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Remove the legacy logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Remove the legacy logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dependencies: Drop the legacy logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

problem: Store a reference to the context

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Store a reference to the context

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: db: Replace legacy logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Replace (most of) the legacy logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

logging: Make the legacy logger configurable

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Move to new logging in pakfire.c

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: Make sure we hold the GIL when jumping into the logging callback

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Re-enable jail tests that pass

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: Pakfire.execute(): Fix parsing some arguments

There have been a couple of problems here when no or invalid values have
been passed.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Fix path to test configuration file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Test the locally built binaries

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Dump log onto the console for Python tests

This is not very elegant, but I don't have a better way to do this now.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: Add tests for the Archive class

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add functions to make opening files in the test env easier

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add Python tests for context

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: ctx: Cleanup code that dereferences the logging function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: ctx: Setup the default logger

There was some code that started implementing this, but weirdly it was
never called...

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Disable all jail tests

Those mess up the console.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Migrate other Python tests to the new framework

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Build a common basis for Python tests

This new class has some methods that make it easy for us to set up some
simple Pakfire environments.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Fix syntax errors in keys tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Remove dummy Python test

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

httpclient: Don't store finished transfers internally

This caused a recursion in reference counting resulting in the HTTP
client and all finished transfers never being freed.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Fix cgroup tests building from source

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Reset all callbacks after execution

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Remove unnecessary pakfire_jail_exec wrapper function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Remove callbacks from command calls

This makes those functions having fewer arguments which should help us
to write cleaner code.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Replace communication callbacks by setting callbacks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Add functions to set standard input/output callbacks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Fix incorrect variable name

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Drop extra function to check if buffer is full

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Rename PTY forwarding flags

The term flags is slightly overused and makes things confusing.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Move struct declarations out of the large struct

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Remove unused stdout/stderr buffers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Drop custom log callback stuff

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Drop setting jail callback and use output callback instead

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Implement sending data into standard input

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Keep reading from/writing to PTY for as long as there is work to do

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Forward function names of child processes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Remove duplicate logging function

There were two functions essentially doing the same, so one can go.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Honour the buffer length when forwarding log messages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: PTY forwarding: Call the output callback if available

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Only connect the current terminal if requested

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Do not try to attempt any TTY operations if we don't have a TTY

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Refactor how to drain logging buffers with callbacks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Make PTY forwarding a flag and remove interactive bool

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Use the "fill buffer" function for logging, too

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Align processing of file descriptors in the event loop

This is slightly easier to read than checking the event type first and
then handle the rest.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Implement PTY forwarding

This replaces the previous pipe forwarding with a new controlling PTY
that is set up for each jail.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Only try to restore file descriptors if they are still open

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Fix setting raw mode only on the correct side

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Store flags of stdin/stdout

We will need to restore them after we are finish the PTY forwarding.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: No longer create /dev/console in the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Fix creating symlinks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Setup PTY in the master process and add it to the event loop

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Create a better struct to hold all PTY related stuff

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Have the child process allocate a new PTY

The master file descriptor is being sent to the parent process.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Fix FD check in stdin

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Bring back the UNIX domain socket between child/parent

We will need this later to pass around file descriptors.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Bring back helper function to add FDs to epoll()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "jail: This changes how we launch sub-processes"

This reverts commit 9b171c6a54a5f8e42ba3f11f285af601aecaa303.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Commit some disabled code to set up a PTY

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Create a function to create relative symlinks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Add function to compute relative paths

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Add comment about mounting /proc

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Mount some things in the outer namespace and some in the inner one

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Log the mountpoints when entering the inner namespaces

There is only little sense in logging the mount table of the host system
as it only makes the debug log very noisy.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Drop using libmount

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: os.h: Add missing header for pid_t

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Use the parse helpers to log /proc/self/mounts

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parse: Remove any trailing line breaks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parse: Move parse function into an extra file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: setgroups: Use pakfire_file_write

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Actually exit if something went wrong during initialization

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Don't let the second child die when the first child finishes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Don't fail if cgroup stats could not be read

This is kind of a fire and forget situation, but should be good enough.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Remove signalfd stuff

I don't think that we need this.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

compress: Be less verbose when walking through the file system

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Fix format character when setting GIDs

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: This changes how we launch sub-processes

This patch changes that we will launch a new process in a new mount
namespace which will then set up that namespace and fork another child
into a new user/network/time/etc. namespace.

This is not completed as the internal mount namespace is not set up
correctly, yet.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroup: Be less verbose when parsing stats

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Use eventfd_read/write convenience handlers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Correctly compile out debug stuff when not enabled

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Remove unused function to check for mountpoints

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Drop the stupid namespace stuff

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Make changing mount operation not dependant on pakfire

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Check for root privileges when needed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Implement another version for tmpfiles

O_TMPFILE requires filesystem support which is sadly not available for
NFS.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Try again for temporary issues on API calls

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: xfer: Fix digest check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Translate any errors into our own error codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Correctly truncate if the download failed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Fail on any HTTP return codes >= 400

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Receive any error messages from cURL

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Remove restoring the mtime of downloads

The servers don't generally send this information.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Set mtime only if we received one

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>