Don't perform LDAP search with empty input

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/buildservice/ldap.py b/src/buildservice/ldap.py
index ca329305a577daa8e5b7895a59cc796d15a01fb8..efa08ee95da004fb9f46b9c81e7d8f689c3ed30c 100644 (file)
--- a/src/buildservice/ldap.py
+++ b/src/buildservice/ldap.py
@@ -66,6 +66,10 @@ class LDAP(base.Object):
                return self.get_dn_by_uid(name) or self.get_dn_by_mail(name)
 
        def get_user_by_uid(self, uid, **kwargs):
+               # Do not execute search with empty uid
+               if not uid:
+                       return None, None
+
                result = self.search("(&(objectClass=posixAccount)(uid=%s))" % uid, limit=1, **kwargs)
                for dn, attrs in result:
                        return dn, attrs
@@ -73,6 +77,10 @@ class LDAP(base.Object):
                return None, None
 
        def get_user_by_mail(self, mail, **kwargs):
+               # Do not execute search with empty mail
+               if not mail:
+                       return None, None
+
                result = self.search("(&(objectClass=posixAccount)(mail=%s))" % mail, limit=1, **kwargs)
                for dn, attrs in result:
                        return dn, attrs