]> git.ipfire.org Git - people/arne_f/kernel.git/commit
video: fbdev: fix OOB read in vga_8planes_imageblit()
authorTetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Mon, 31 Aug 2020 10:37:00 +0000 (19:37 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Sep 2020 08:46:31 +0000 (10:46 +0200)
commit0472aa0c36c7bb3756629a3bbc834604167567f7
treee4b4609d4694aaa91f9612fab81c7efd00980b01
parente0db83ee7f61d21cd04c27589874370dd7141ac8
video: fbdev: fix OOB read in vga_8planes_imageblit()

commit bd018a6a75cebb511bb55a0e7690024be975fe93 upstream.

syzbot is reporting OOB read at vga_8planes_imageblit() [1], for
"cdat[y] >> 4" can become a negative value due to "const char *cdat".

[1] https://syzkaller.appspot.com/bug?id=0d7a0da1557dcd1989e00cb3692b26d4173b4132

Reported-by: syzbot <syzbot+69fbd3e01470f169c8c4@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/90b55ec3-d5b0-3307-9f7c-7ff5c5fd6ad3@i-love.sakura.ne.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/video/fbdev/vga16fb.c