]> git.ipfire.org Git - people/arne_f/kernel.git/commit
USB: UHCI: check for wakeup/suspend race
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 18 Oct 2013 15:19:18 +0000 (11:19 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 19 Oct 2013 21:12:14 +0000 (14:12 -0700)
commit1c124c9962b4ee6555fd6179ca318c2ad3a30354
treefa7fbe6e50c27485a50c421f808eefc141c614ba
parentb8efdafb4005a79ab2305f8af31025d49292d4cf
USB: UHCI: check for wakeup/suspend race

hcd-pci.c in usbcore contains a check for wakeup requests racing with
controller suspend.  This check is going to be moved out of usbcore
and into the individual controller drivers, where it can apply to all
platforms, not just PCI.

This patch adds the check to uhci-hcd.  Ironically, none of the
non-PCI platform drivers for uhci-hcd implement suspend/resume.
Nevertheless, this change is needed to accomodate the upcoming change
to usbcore.

The patch also removes an outdated check of the root hub state.  For
one thing, the PM layer has long been quite reliable about suspending
root hubs before controllers.  For another, virtually the same check
is also made in hcd-pci.c; there's no point in repeating it.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/uhci-pci.c