]> git.ipfire.org Git - people/arne_f/kernel.git/commit
Staging: lustre: remove two build warnings
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Dec 2018 12:50:37 +0000 (13:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Dec 2018 08:20:29 +0000 (09:20 +0100)
commit2f5b76794a49a1e885b7d95534e57eea8e38cd15
tree2abe9b08c0b1e2b24fe855490c035e5deba629fc
parent569fc4ffb5de8f12fe01759f0b85098b7b9bba8e
Staging: lustre: remove two build warnings

[for older kernels only, lustre has been removed from upstream]

When someone writes:
strncpy(dest, source, sizeof(source));
they really are just doing the same thing as:
strcpy(dest, source);
but somehow they feel better because they are now using the "safe"
version of the string functions.  Cargo-cult programming at its
finest...

gcc-8 rightfully warns you about doing foolish things like this.  Now
that the stable kernels are all starting to be built using gcc-8, let's
get rid of this warning so that we do not have to gaze at this horror.

To dropt the warning, just convert the code to using strcpy() so that if
someone really wants to audit this code and find all of the obvious
problems, it will be easier to do so.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lnet/lnet/config.c
drivers/staging/lustre/lustre/lmv/lmv_obd.c