]> git.ipfire.org Git - people/arne_f/kernel.git/commit
nfsd: fix deadlock secinfo+readdir compound
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 3 Mar 2016 00:36:21 +0000 (16:36 -0800)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 16 Mar 2016 14:51:21 +0000 (10:51 -0400)
commit2f6fc056e899bd0144a08da5cacaecbe8997cd74
treed3fcc2454af13cf417413152c3c229e6b5d45676
parent0f1738a10bf03f6406b7b071c2a76b22e687d9c9
nfsd: fix deadlock secinfo+readdir compound

nfsd_lookup_dentry exits with the parent filehandle locked.  fh_put also
unlocks if necessary (nfsd filehandle locking is probably too lenient),
so it gets unlocked eventually, but if the following op in the compound
needs to lock it again, we can deadlock.

A fuzzer ran into this; normal clients don't send a secinfo followed by
a readdir in the same compound.

Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4proc.c