]> git.ipfire.org Git - people/arne_f/kernel.git/commit
xen: Prevent buffer overflow in privcmd ioctl
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Apr 2019 15:12:17 +0000 (18:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2019 06:36:47 +0000 (08:36 +0200)
commit356bcb7b4eaa2fb92332344b5d1c1e47103b6999
tree1f858c11ae833daf7d8b3ed39269aea3db1c1a2f
parent79bedcb095bdc5c83db65180b414a8b0ac89b91d
xen: Prevent buffer overflow in privcmd ioctl

commit 42d8644bd77dd2d747e004e367cb0c895a606f39 upstream.

The "call" variable comes from the user in privcmd_ioctl_hypercall().
It's an offset into the hypercall_page[] which has (PAGE_SIZE / 32)
elements.  We need to put an upper bound on it to prevent an out of
bounds access.

Cc: stable@vger.kernel.org
Fixes: 1246ae0bb992 ("xen: add variable hypercall caller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/include/asm/xen/hypercall.h