]> git.ipfire.org Git - people/arne_f/kernel.git/commit
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 7 Mar 2019 22:56:51 +0000 (15:56 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jun 2019 09:54:55 +0000 (11:54 +0200)
commit46e2c2c16a14518c608922b0c86d3a11705c4743
treea1202a34390e7100b8307806b22f4e510526b506
parent7cb42a3549ff2e8bd7bb4d342893f0bd5c82c7fa
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher

[ Upstream commit 89e28da82836530f1ac7a3a32fecc31f22d79b3e ]

When building with -Wsometimes-uninitialized, Clang warns:

drivers/soc/mediatek/mtk-pmic-wrap.c:1358:6: error: variable 'rdata' is
used uninitialized whenever '||' condition is true
[-Werror,-Wsometimes-uninitialized]

If pwrap_write returns non-zero, pwrap_read will not be called to
initialize rdata, meaning that we will use some random uninitialized
stack value in our print statement. Zero initialize rdata in case this
happens.

Link: https://github.com/ClangBuiltLinux/linux/issues/401
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/mediatek/mtk-pmic-wrap.c