]> git.ipfire.org Git - people/arne_f/kernel.git/commit
drivers/net/wan/lapbether: Set network_header before transmitting
authorXie He <xie.he.0141@gmail.com>
Wed, 26 Aug 2020 03:03:53 +0000 (20:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Sep 2020 08:46:27 +0000 (10:46 +0200)
commit479fb037277d2fec63df3a8ae6492206c3e771a8
treee058d1f020e02569c8524b968526ebbd1aaf1954
parentcea06c8a39aa862e4aa2b82074abb43c0a4d989a
drivers/net/wan/lapbether: Set network_header before transmitting

[ Upstream commit 91244d108441013b7367b3b4dcc6869998676473 ]

Set the skb's network_header before it is passed to the underlying
Ethernet device for transmission.

This patch fixes the following issue:

When we use this driver with AF_PACKET sockets, there would be error
messages of:
   protocol 0805 is buggy, dev (Ethernet interface name)
printed in the system "dmesg" log.

This is because skbs passed down to the Ethernet device for transmission
don't have their network_header properly set, and the dev_queue_xmit_nit
function in net/core/dev.c complains about this.

Reason of setting the network_header to this place (at the end of the
Ethernet header, and at the beginning of the Ethernet payload):

Because when this driver receives an skb from the Ethernet device, the
network_header is also set at this place.

Cc: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wan/lapbether.c