]> git.ipfire.org Git - people/arne_f/kernel.git/commit
drm/vmwgfx: integer underflow in vmw_cmd_dx_set_shader() leading to an invalid read
authorMurray McAllister <murray.mcallister@gmail.com>
Mon, 20 May 2019 09:57:34 +0000 (21:57 +1200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jun 2019 06:20:58 +0000 (08:20 +0200)
commit956916b54207ba46d4b921facbdf5728f064a653
tree4c8e052dc60175f26c086ff6a69cd790ab7713dd
parent4739012890395a463e6a7439d552367704baefbf
drm/vmwgfx: integer underflow in vmw_cmd_dx_set_shader() leading to an invalid read

commit 5ed7f4b5eca11c3c69e7c8b53e4321812bc1ee1e upstream.

If SVGA_3D_CMD_DX_SET_SHADER is called with a shader ID
of SVGA3D_INVALID_ID, and a shader type of
SVGA3D_SHADERTYPE_INVALID, the calculated binding.shader_slot
will be 4294967295, leading to an out-of-bounds read in vmw_binding_loc()
when the offset is calculated.

Cc: <stable@vger.kernel.org>
Fixes: d80efd5cb3de ("drm/vmwgfx: Initial DX support")
Signed-off-by: Murray McAllister <murray.mcallister@gmail.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c