]> git.ipfire.org Git - people/arne_f/kernel.git/commit
netns: provide pure entropy for net_hash_mix()
authorEric Dumazet <edumazet@google.com>
Wed, 27 Mar 2019 15:21:30 +0000 (08:21 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2019 06:38:40 +0000 (08:38 +0200)
commita1c2f3229734a4bb8d5ac008c0a67e025aa11547
tree30982adf30a3fd852de5448330bfaca834f64fba
parent53a1906859a2ec1d2b5c33102086ce3e03ec0b37
netns: provide pure entropy for net_hash_mix()

[ Upstream commit 355b98553789b646ed97ad801a619ff898471b92 ]

net_hash_mix() currently uses kernel address of a struct net,
and is used in many places that could be used to reveal this
address to a patient attacker, thus defeating KASLR, for
the typical case (initial net namespace, &init_net is
not dynamically allocated)

I believe the original implementation tried to avoid spending
too many cycles in this function, but security comes first.

Also provide entropy regardless of CONFIG_NET_NS.

Fixes: 0b4419162aa6 ("netns: introduce the net_hash_mix "salt" for hashes")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Amit Klein <aksecurity@gmail.com>
Reported-by: Benny Pinkas <benny@pinkas.net>
Cc: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/net_namespace.h
include/net/netns/hash.h
net/core/net_namespace.c