]> git.ipfire.org Git - people/arne_f/kernel.git/commit
devres: fix a for loop bounds check
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 21 Sep 2015 16:21:51 +0000 (19:21 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Mar 2016 23:06:48 +0000 (15:06 -0800)
commita255d55190d702c217eef87de067b14c25a5c2d2
treece4a342875c936b330cb2f67f610f44a21ea0edf
parente7f460fef9a6d391abfca3b9819de348e449461e
devres: fix a for loop bounds check

commit 1f35d04a02a652f14566f875aef3a6f2af4cb77b upstream.

The iomap[] array has PCIM_IOMAP_MAX (6) elements and not
DEVICE_COUNT_RESOURCE (16).  This bug was found using a static checker.
It may be that the "if (!(mask & (1 << i)))" check means we never
actually go past the end of the array in real life.

Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/devres.c