]> git.ipfire.org Git - people/arne_f/kernel.git/commit
irqchip/mbigen: Don't clear eventid when freeing an MSI
authorJianguo Chen <chenjianguo3@huawei.com>
Wed, 20 Mar 2019 18:54:21 +0000 (18:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Apr 2019 07:07:49 +0000 (09:07 +0200)
commita95d4e6039e00c71b0e97e713f9b129da852ae36
tree1b3c187c9de19e612d1bd11c6846f710c7322565
parentddfa93e6b1b4bd7fd7015b90da704e4d2e38f1ec
irqchip/mbigen: Don't clear eventid when freeing an MSI

[ Upstream commit fca269f201a8d9985c0a31fb60b15d4eb57cef80 ]

mbigen_write_msg clears eventid bits of a mbigen register
when free a interrupt, because msi_domain_deactivate memset
struct msg to zero. Then multiple mbigen pins with zero eventid
will report the same interrupt number.

The eventid clear call trace:
                free_irq
                __free_irq
                irq_shutdown
                irq_domain_deactivate_irq
                __irq_domain_deactivate_irq
                __irq_domain_deactivate_irq
                msi_domain_deactivate
                platform_msi_write_msg
                mbigen_write_msg

Signed-off-by: Jianguo Chen <chenjianguo3@huawei.com>
[maz: massaged subject]
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-mbigen.c