]> git.ipfire.org Git - people/arne_f/kernel.git/commit
KVM: PPC: Book3S HV: Hold kvm->lock around call to kvmppc_update_lpcr
authorPaul Mackerras <paulus@ozlabs.org>
Mon, 11 Sep 2017 06:05:30 +0000 (16:05 +1000)
committerPaul Mackerras <paulus@ozlabs.org>
Tue, 12 Sep 2017 06:02:27 +0000 (16:02 +1000)
commitcf5f6f3125241853462334b1bc696f3c3c492178
tree4108b0c8c4d6bab9772d8ff03f20461aa1887385
parentd222af072380c4470295c07d84ecb15f4937e365
KVM: PPC: Book3S HV: Hold kvm->lock around call to kvmppc_update_lpcr

Commit 468808bd35c4 ("KVM: PPC: Book3S HV: Set process table for HPT
guests on POWER9", 2017-01-30) added a call to kvmppc_update_lpcr()
which doesn't hold the kvm->lock mutex around the call, as required.
This adds the lock/unlock pair, and for good measure, includes
the kvmppc_setup_partition_table() call in the locked region, since
it is altering global state of the VM.

This error appears not to have any fatal consequences for the host;
the consequences would be that the VCPUs could end up running with
different LPCR values, or an update to the LPCR value by userspace
using the one_reg interface could get overwritten, or the update
done by kvmhv_configure_mmu() could get overwritten.

Cc: stable@vger.kernel.org # v4.10+
Fixes: 468808bd35c4 ("KVM: PPC: Book3S HV: Set process table for HPT guests on POWER9")
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
arch/powerpc/kvm/book3s_hv.c