]> git.ipfire.org Git - people/arne_f/kernel.git/commit
bnxt_en: Fix NULL pointer dereference in a failure path during open.
authorMichael Chan <michael.chan@broadcom.com>
Tue, 21 Feb 2017 00:25:17 +0000 (19:25 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Feb 2017 02:59:15 +0000 (21:59 -0500)
commitdaf1f1e7841138cb0e48d52c8573a5f064d8f495
tree02f76b565b4e3fa80bee41bacc1da0c851e92684
parent4e00338a61998de3502d0428c4f71ffc69772316
bnxt_en: Fix NULL pointer dereference in a failure path during open.

If bnxt_hwrm_ring_free() is called during a failure path in bnxt_open(),
it is possible that the completion rings have not been allocated yet.
In that case, the completion doorbell has not been initialized, and
calling bnxt_disable_int() will crash.  Fix it by checking that the
completion ring has been initialized before writing to the completion
ring doorbell.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c