]> git.ipfire.org Git - people/arne_f/kernel.git/commit
qmi_wwan: apply SET_DTR quirk to the SIMCOM shared device ID
authorBjørn Mork <bjorn@mork.no>
Fri, 25 May 2018 13:00:20 +0000 (15:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jan 2019 16:14:48 +0000 (17:14 +0100)
commitdf088bbe01e1234b14d8366416d98fde99bbd81e
treea0ae8675842bda70269aa3cc321c594cd727e78b
parent5b48bec5f6c818b7e4ca7c7ae7d7adfa742e9913
qmi_wwan: apply SET_DTR quirk to the SIMCOM shared device ID

commit 102cd909635612c0be784a519651954a7924c786 upstream.

SIMCOM are reusing a single device ID for many (all of their?)
different modems, based on different chipsets and firmwares. Newer
Qualcomm chipset generations require setting DTR to wake the QMI
function.  The SIM7600E modem is using such a chipset, making it
fail to work with this driver despite the device ID match.

Fix by unconditionally enabling the SET_DTR quirk for all SIMCOM
modems using this specific device ID.  This is similar to what
we already have done for another case of device IDs recycled over
multiple chipset generations: 14cf4a771b30 ("drivers: net: usb:
qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")

Initial testing on an older SIM7100 modem shows no immediate side
effects.

Reported-by: Sebastian Sjoholm <sebastian.sjoholm@gmail.com>
Cc: Reinhard Speyerer <rspmn@arcor.de>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/usb/qmi_wwan.c